From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225nFuZ7TT6FqxGmBJQ0D8JeKcoYtM9mPEEAzyfzUUz7SfbaCkOBgbc/YxKtovnAFvM1Qjdl ARC-Seal: i=1; a=rsa-sha256; t=1516748300; cv=none; d=google.com; s=arc-20160816; b=0VbJvNDm9VRHB0MYSNz4UEEN6ShVQ7xy0onMq1fzxDIvkIswxBqz8oqCukkwpOOPvI V/U6+zaElxmSLKOAADrJ4OvTUv8Taxtaw0MdYudsKG8JapLmDh4A4MckL+HdG1V6R9Zm 5JfAABg3mWUrmsAwpK1ITG0R8nZyBrNjvLalhXGq31qRFkMkmIOypdkPi2UDWddlvpaF 5BVNf+Dm/JIuBpExQR89dGia0iWFCyc80n56KGuxD9ewpVbEi+ahX32muVPF3GyFp7Jr TbcQoa7Ozofjt0vZmS/CP29IZNhAGriEZHg9c5yfDu/RYhYryS2JIizf8HalyTKeMb9g b24Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=WUV+iFSbC1bhvYTPSSVGpORNvOduLvFe6l+kKTtovG0=; b=mGK0NijlayxUJYNk5WLffT39QJiLYAzifsX0Wm/Ee7G6mCZbgIv0Hn8zdqTj2J//NY 9qJL5WY/N+fq5+2pn4DG5IXtzSW0O6ZWzvfELiJ+cIZX3ZfJ3R8ZuSPTwCSwUFKoDyo0 KgQn4KUTGhkZHDNvzLxePIeMlxBJDInGNb2JqePDPENQrUi5292CvpXl9qIGAGXBxZ2Q FP0/SKzrQPPEjuY9ATp38K5lxWNcUzatiGY1o3QpGGC1jtEmFytSJcH9oTFfFyU4Dwz0 jnkbutNAX5w+3bYRIECcJtNTqHUHV3Ks1iAacnfn6Lhp/BMfO/2Wn5q9JPi9KN29iciw xCCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=OGKNLsPQ; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=OGKNLsPQ; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Tue, 23 Jan 2018 14:58:17 -0800 From: Darren Hart To: Vadim Pasternak Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us Subject: Re: [patch v10 4/6] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface Message-ID: <20180123225817.GB16464@fury> References: <1516739665-132304-1-git-send-email-vadimp@mellanox.com> <1516739665-132304-4-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516739665-132304-4-git-send-email-vadimp@mellanox.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590409505885907527?= X-GMAIL-MSGID: =?utf-8?q?1590425866285937133?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Tue, Jan 23, 2018 at 08:34:23PM +0000, Vadim Pasternak wrote: > Restructure mlxreg header for unification of hotplug item definitions. > > Unify hotplug items to allow any kind of item (power controller, fan > eeprom, psu eeprom, asic health) in common way. > > Use a hardware independent regmap interface, enabling the support of > hotplug events over programmable devices attached to different bus > types, such as I2C, LPC, or SPI. Add a device node to the > mlxreg_core_data structure. > > Signed-off-by: Vadim Pasternak > Acked-by: Andy Shevchenko > --- > v10->v9: > Fixes provided by Vadim: > - add missed description of pdev_hotplug for struct mlxplat_priv; I didn't see this in the diff from my version to this one. > - remove struct mlxplat_mlxcpld_regmap_context, which contains only > the field with base address. Instead obtain locally defined base > address by devm_ioport_map in mlxplat_init and pass it to > devm_regmap_init; > - modify mlxplat_mlxcpld_reg_read/write to use directly pointer to > context; Also adds incorrect conversion of tabs to spaces in at least 3 locations ... I had also corrected various typos and the copyright statement, as well as reworked the commit messages. So at this point, I'd rather see these as changes on top of what I have cleaned up. Please compare what you have here with: https://github.com/dvhart/linux-pdx86/tree/review-dvhart-mellanox-v10 And send me any changes strictly on top of that. Are you anticipating any additional changes beyond those in this version? -- Darren Hart VMware Open Source Technology Center