From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-874563-1516769075-2-14594135017260714294 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES enda, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516769075; b=ezL+Wwk7J9NG6gOr71AR+GmL2y9tfucJ6UcN0mHALjnduCI WPCtNneMt7/venZn7qjDknKwoIEaNKoU79FaSBliorVeniDd3wi4288IA5j9qE85 Dc5XxUSQ22OL5BSC1HNkhaY/XHnaUQNKZhgeiTMSwikWLpXowwkiMSUwjjawoBHu 6yBnGOoYsnAELqcrvcX9Mg0w80os3/IKRdMEbsADPULWe3tVUyX18JIRIBu/nmHu 1GFLFLU/aPZOGg/4zhujCtpbKT45lzsmJsdo8TPOmKlDki+r65xrgg1rQiR1JSJA +vMwMnCPLysAqzjqWdpLMzXlzlW0wntZcFmWMRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1516769075; bh=JMSQo/ WxCgTMiMYQYaOwa1Pl/TfJ9okfSVypkS9jJBc=; b=SfIJBE1YlZ3wMJyPrw/Q4e s3ty64MYXZDVgWFLkeeB8/1vEClE3GypD2kyI0obnwYnnIdSCuXr1Tvnh1ejP4Yu 01MHA8C/epMVOadD/k4JjoYc8S/XRlcXGUmzIwFePeMec1N109CLW/d1Sa/wri98 8L048s2z2kNAsbI6e1P5k1/IAMch5RqV5BWRHYvsw3Gj47IXEhR26usIrEIALGM4 pdQS3GcOBnVKzEietSpnobvxHeACSNvONvE/6HoiOnpOVoPRHIJPxzhfu1VI8guK FwtYIX20DZDz82i4ZrOfBE8a0Oii9KCCoU3xE78US1dv1GpKfpCgHiVbC9lJKZdg == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=SvGPJ9lk x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=SvGPJ9lk x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932869AbeAXEoI (ORCPT ); Tue, 23 Jan 2018 23:44:08 -0500 Received: from mail-sn1nam01on0134.outbound.protection.outlook.com ([104.47.32.134]:5532 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932639AbeAXEQr (ORCPT ); Tue, 23 Jan 2018 23:16:47 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Colin Ian King , Felipe Balbi , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 099/100] usb: gadget: don't dereference g until after it has been null checked Thread-Topic: [PATCH AUTOSEL for 4.14 099/100] usb: gadget: don't dereference g until after it has been null checked Thread-Index: AQHTlMnw/XXYTDS0J0ylGvbm0k/AsA== Date: Wed, 24 Jan 2018 04:15:17 +0000 Message-ID: <20180124041414.32065-99-alexander.levin@microsoft.com> References: <20180124041414.32065-1-alexander.levin@microsoft.com> In-Reply-To: <20180124041414.32065-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0727;7:/jMNk8mf2ck+tahbm+IxCiz68YMjQvkEBj0fpf97gOTmCjDY6CE17aVVrw4HS9M0NBtO39ezbbQV5Devq+NTg0L8xHgo9xiecmDGQSntT7m046/Hld/tSNfl1DXHjD5qdSenfeleEwc2+Uq6a00VOdy2ULS/J+mGlhQwdGEFhbFB7/dEX8XbDTo7+SZtSLn68/LsFk0B1Srg1F3+xujENf3+YUWY8f/DkYdEq2yVSnN9oK1yjKehsMMdO4dNDnCP x-ms-office365-filtering-correlation-id: d37da803-f0d7-4c1e-4636-08d562e1456c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB0727; x-ms-traffictypediagnostic: DM5PR2101MB0727: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(198206253151910)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3231046)(2400081)(944501161)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041288)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB0727;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0727; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(396003)(366004)(39380400002)(39860400002)(376002)(189003)(199004)(86612001)(6506007)(106356001)(76176011)(6346003)(54906003)(575784001)(86362001)(2501003)(110136005)(1076002)(7736002)(5250100002)(3660700001)(316002)(26005)(102836004)(2950100002)(6666003)(99286004)(97736004)(22452003)(107886003)(6436002)(53936002)(478600001)(66066001)(14454004)(2900100001)(6512007)(2906002)(5660300001)(8936002)(4326008)(10290500003)(305945005)(10090500001)(68736007)(25786009)(81166006)(72206003)(36756003)(8676002)(81156014)(3846002)(6116002)(3280700002)(105586002)(6486002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0727;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: hBzex2TnzMrE72Hx9IVDrPQ61lfgOJv3Kf058rdYN16K/PS0yi3sMyzIURx8cawismf7Q+RGOEPHi1CBBNPFXQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: d37da803-f0d7-4c1e-4636-08d562e1456c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 04:15:17.6335 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0727 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Colin Ian King [ Upstream commit b2fc059fa549fe6881d4c1f8d698b0f50bcd16ec ] Avoid dereferencing pointer g until after g has been sanity null checked; move the assignment of cdev much later when it is required into a more local scope. Detected by CoverityScan, CID#1222135 ("Dereference before null check") Fixes: b785ea7ce662 ("usb: gadget: composite: fix ep->maxburst initializati= on") Signed-off-by: Colin Ian King Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/composite.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.= c index 5d061b3d8224..ed9346f0b000 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -150,7 +150,6 @@ int config_ep_by_speed(struct usb_gadget *g, struct usb_function *f, struct usb_ep *_ep) { - struct usb_composite_dev *cdev =3D get_gadget_data(g); struct usb_endpoint_descriptor *chosen_desc =3D NULL; struct usb_descriptor_header **speed_desc =3D NULL; =20 @@ -229,8 +228,12 @@ ep_found: _ep->maxburst =3D comp_desc->bMaxBurst + 1; break; default: - if (comp_desc->bMaxBurst !=3D 0) + if (comp_desc->bMaxBurst !=3D 0) { + struct usb_composite_dev *cdev; + + cdev =3D get_gadget_data(g); ERROR(cdev, "ep0 bMaxBurst must be 0\n"); + } _ep->maxburst =3D 1; break; } --=20 2.11.0