From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752255AbeAXFAn (ORCPT ); Wed, 24 Jan 2018 00:00:43 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:37197 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbeAXFAk (ORCPT ); Wed, 24 Jan 2018 00:00:40 -0500 X-Google-Smtp-Source: AH8x2261sUAgyeY1AMKq6tejdqsVUXKiwaof19oyYchcysJO2Q3nSuJT5kJMvdJw0TqT5CixQQfmXg== Date: Wed, 24 Jan 2018 14:00:35 +0900 From: Sergey Senozhatsky To: Steven Rostedt Cc: Sergey Senozhatsky , Tejun Heo , Rik van Riel , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, kernel-team@fb.com, Sergey Senozhatsky , Petr Mladek Subject: Re: [PATCH] lockdep: Avoid triggering hardlockup from debug_show_all_locks() Message-ID: <20180124045843.GD651@jagdpanzerIV> References: <20180122220055.GB1771050@devbig577.frc2.facebook.com> <1516734237.31954.17.camel@fb.com> <20180123205706.GH1771050@devbig577.frc2.facebook.com> <20180123160054.325ff326@gandalf.local.home> <20180123211154.GI1771050@devbig577.frc2.facebook.com> <20180124024955.GB651@jagdpanzerIV> <20180123215438.0257fa3e@vmware.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180123215438.0257fa3e@vmware.local.home> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (01/23/18 21:54), Steven Rostedt wrote: > > > Another problem, and I mentioned it somewhere in another email, is that > > upstream printk people don't receive enough [if any at all] feedback from > > guys who face printk issues. That's why every time printk_kthread re-surfaces > > the reaction is "this is not a real problem, no one is seeing printk issues > > like these, you idiot!". It'd be great to have more "we need ABC, because of > > XYZ, but printk crashes the system. Here is the backtrace, fix it" reports. > > As of now, those things mostly are not reported, that's why people are not > > convinced. Just my 5 cents. > > If you are seeing these issues, have whoever is reporting them to Cc > LKML, and those of us that would care to listen. OK. The lack of reports can also signify that we need to change the way we handle those reports. If we are going to reply "yes, your system crashed while doing completely innocent printout, but if we fix it then we can increase by 0.0001% chances of not getting any printouts at all in that corner case when your system is in recursive double panic over the latest bitcoin price and your keyboard is on fire" then I don't think people will care to report anything. Maybe Tejun will be kind enough to shed some light on how often FB fleet suffer from printk related issues, or what are the most common scenarios, etc. [sensitive information can be reported "off list"] -ss