From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932496AbeAXH1d (ORCPT ); Wed, 24 Jan 2018 02:27:33 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:39512 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932108AbeAXH1b (ORCPT ); Wed, 24 Jan 2018 02:27:31 -0500 X-Google-Smtp-Source: AH8x224iB2Ct4M3t7T8i6A4x2SONnnBvLCCkUu4wgRwL52icCvvq0OMMgz4pe8Zf7uShlcRByyl8sw== Date: Wed, 24 Jan 2018 10:27:43 +0300 From: Serge Semin To: Marcin Nowakowski Cc: ralf@linux-mips.org, miodrag.dinic@mips.com, jhogan@kernel.org, goran.ferenc@mips.com, david.daney@cavium.com, paul.gortmaker@windriver.com, paul.burton@mips.com, alex.belits@cavium.com, Steven.Hill@cavium.com, alexander.sverdlin@nokia.com, matt.redfearn@mips.com, kumba@gentoo.org, James.hogan@mips.com, Peter.Wotton@mips.com, Sergey.Semin@t-platforms.ru, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/14] MIPS: memblock: Mark present sparsemem sections Message-ID: <20180124072743.GA31120@mobilestation> References: <20180117222312.14763-1-fancer.lancer@gmail.com> <20180117222312.14763-8-fancer.lancer@gmail.com> <7246ebaa-0ffa-f012-c18e-269b1e0130e6@mips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7246ebaa-0ffa-f012-c18e-269b1e0130e6@mips.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Marcin On Wed, Jan 24, 2018 at 07:13:03AM +0100, Marcin Nowakowski wrote: > Hi Serge, > > On 17.01.2018 23:23, Serge Semin wrote: > >If sparsemem is activated all sections with present pages must > >be accordingly marked after memblock is fully initialized. > > > >Signed-off-by: Serge Semin > >--- > > arch/mips/kernel/setup.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > >diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > >index b121fa702..6df1eaf38 100644 > >--- a/arch/mips/kernel/setup.c > >+++ b/arch/mips/kernel/setup.c > >@@ -778,7 +778,7 @@ static void __init request_crashkernel(struct resource *res) > > static void __init arch_mem_init(char **cmdline_p) > > { > >- struct memblock_region *reg; > >+ struct memblock_region *reg __maybe_unused; > > nit: reg is used here. It becomes __maybe_unused in patch 8. > Right. I'll move __maybe_unused change to the patch 8. -Sergey > > Marcin