From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1772008-1516804204-2-14992578841508821598 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516804203; b=ZXoADdQbEMpy+FgASVmdoP3dBfbEgo16pv+FsTbrjw4BJC6 uUKoZVJcZ9rx/GT4hdwdv/DCe8N2Fa8NRR+t2ug8VOOsyj+f7oalqyCO1ITPnTxJ QESK4xf3LinApS7iV8iptCvzVIpQTKz+YeLZaFJwFtZihRc8LQq291rc5PELT8KA ej+FrhyK4sggA8tFjB3N8nBX/YJ8Z0TwsG2wQFbR3MPMNYymVYp6gtywOAjtuQnB mxUy4Qk1KuHbTua4vEymm7T4gquaNGP5L6zTxVmYXpOeej1Cc068POc80fY8ayaj 5tvSz4cKhcKfRI7lRVzRmH5UteBFoyBgOQrobcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1516804203; bh=S d8Jo5XRFkanMAxAxs3SNve/Qw+6TnfIaw6z+rGCrBI=; b=wChKZvTh0v3WKW3dT tbIWCzYdiYpStgWtUfYS4lUBuvWEcvDRUdC/QNe21o+EMTno+dH2lePbF5PoWw+1 SIjn4wJX60jrwDH0HpBlLFX6zW4ROKuN3Hg7paRIms4XeICQaAt9wZ3JHzpCQRID oc3bUpm4TN0WAy5TgxOUaYiBTgEkdTWeWNxCOM3ZaFYp1ja1yri3cx/1zqfetWeK 8+Z+5QQQu0B3r2pZSp/RHo/VnXiIhHNo5mMLVTov/8SHuNxItvJVRfuBEVdi4x66 L4f6ns3If0oCJq4sm7IL7bZy5MGeyH2nqjAL77ztIB4AzeAaV7EKj/2xqnHr8fES ebsGg== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Wed, 24 Jan 2018 15:29:54 +0100 From: Greg Kroah-Hartman To: Dmitry Eremin Subject: Re: [PATCH v3] staging: lustre: separate a connection destroy from free struct kib_conn Message-ID: <20180124142954.GA4658@kroah.com> References: <20180122103924.GB23996@kroah.com> <1516803252-14266-1-git-send-email-dmitry.eremin@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1516803252-14266-1-git-send-email-dmitry.eremin@intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Oleg Drokin , Lustre Development List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 24, 2018 at 05:14:12PM +0300, Dmitry Eremin wrote: > Rewrite the logic of the original commit 4d99b2581eff ("staging: lustre: avoid > intensive reconnecting for ko2iblnd") and move the freeing a struct kib_conn > outside of the function kiblnd_destroy_conn(). The freeing of struct kib_conn > should be depending on the second argument free_conn of function > kiblnd_destroy_conn(struct kib_conn *conn, bool free_conn). If it true the > structure should be freed. > > Fixes: 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for ko2iblnd") > Signed-off-by: Dmitry Eremin > --- > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 7 +++---- > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 2 +- > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 6 ++++-- > 3 files changed, 8 insertions(+), 7 deletions(-) What changed from version 2 and 1? Always included that below the --- line please. 4th try is a charm? :) thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel