From: Mark Brown <broonie@kernel.org>
To: David Lechner <david@lechnology.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()
Date: Wed, 24 Jan 2018 17:04:48 +0000 [thread overview]
Message-ID: <20180124170448.GJ9366@sirena.org.uk> (raw)
In-Reply-To: <5920ae0a-bdb7-7819-8e3f-32b20368a20f@lechnology.com>
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
On Wed, Jan 24, 2018 at 10:27:22AM -0600, David Lechner wrote:
> On 01/24/2018 10:19 AM, Mark Brown wrote:
> > Indeed. It is an improvement but not exactly helpful.
> Would it be better if it said "this regmap does not have driver" instead
> of "(null)"?
That's both not idiomatically good and isn't even true... ideally we'd
be able to get some sort of string out of the user, but otherwise
"nodev" or perhaps printing the pointer to the regmap (to avoid
collisions if there's more than one of these in a system).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-24 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 22:53 [PATCH 0/2] regmap: use debugfs even when no device David Lechner
2018-01-23 22:53 ` [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file() David Lechner
2018-01-24 11:30 ` Mark Brown
2018-01-24 16:04 ` David Lechner
2018-01-24 16:14 ` Lars-Peter Clausen
2018-01-24 16:19 ` Mark Brown
2018-01-24 16:27 ` David Lechner
2018-01-24 17:04 ` Mark Brown [this message]
2018-01-24 16:24 ` David Lechner
2018-01-23 22:53 ` [PATCH 2/2] regmap: use debugfs even when no device David Lechner
2018-02-20 12:10 ` Applied "regmap: use debugfs even when no device" to the regmap tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124170448.GJ9366@sirena.org.uk \
--to=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).