From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bp@alien8.de>
X-Google-Smtp-Source: AH8x224F/HTdLzxKNigY0d7AMGLRftQTBq43OzQNYbaBxbOBGdTPKr3Yz63Np3mKD1qP+jSzuOv3
ARC-Seal: i=1; a=rsa-sha256; t=1516819579; cv=none;
        d=google.com; s=arc-20160816;
        b=uyVhtIVvnjWHidivbgtYBcfnbgPxyPYVmkg7kTmd14BFwsgoAQn3twJ7wHx3pdNXhD
         vREsW4LqFipeCgZxOjlfbxzkpJCX37jDp+HdzGX+k5bSjtuqN7fEi9uE95w0Jatg5IM/
         HlTm8WFp9bPOp0K6dyIxcJMG5DCVeMhkV7NGtTQDohP0hNUshzcPMw1R20i/kmOzvydl
         +Gl+QW/WaRoXdJ08+T8IaN3HeuBkvrSw2Ep1EvqbDqY9KzNsL+IBN9dGCJZnT1fnGHhS
         yAR51Q0DK2MvmfCl+Nl0eB3GKggerJoWQPoFzDEv4HR41NFeB4SU5wqk2y66h0AQ0hS0
         3OrQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=fouYnuLk5eGQwXt024yk71nnsy6npSHcbXX4FZiP1ts=;
        b=XM6SyYKVWzqYqJIp+kvuJ/KtqTXimI1gaOU0lTfqmxkIjdCKde5y+ri6Qdlf16PaoJ
         8iEC8Cy5Itsf9OfHMr24h9iN64ABYAPgHb62GZwrmPlLD0C6ai52slB3FXsYFoRfO1z3
         oRDHr5+zIPnBT8gJjG8w5dJqia4LKwhFCmynsjW5P4gSDcpLrePknQzQP/66skb9mqfu
         7ZjtAgP9wAyfGsYvGQIKtik2aJgoVamr0Jco/u8Lpo0zooHce+ujV9m5b2XDW/PRObQN
         foWIE++VeFVP+1zgMbaUdnc/8DmkYMsu3qWYMgz97HzOGBqSfdghg7Sfo4oD1/plXDtz
         CZjQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de
Date: Wed, 24 Jan 2018 19:46:12 +0100
From: Borislav Petkov <bp@alien8.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Josh Poimboeuf <jpoimboe@redhat.com>, linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@intel.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andi Kleen <ak@linux.intel.com>,
	Arjan Van De Ven <arjan.van.de.ven@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Asit Mallick <asit.k.mallick@intel.com>,
	Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 09/24] jump_label: Add branch hints to
 static_branch_{un,}likely()
Message-ID: <20180124184612.kxlnoa2ajimkzd7x@pd.tnic>
References: <20180123152539.374360046@infradead.org>
 <20180123152638.512294068@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180123152638.512294068@infradead.org>
User-Agent: NeoMutt/20170609 (1.8.3)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1590397857505687509?=
X-GMAIL-MSGID: =?utf-8?q?1590500606969331327?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Tue, Jan 23, 2018 at 04:25:48PM +0100, Peter Zijlstra wrote:
> For some reason these were missing, I've not observed this patch
> making a difference in the few code locations I checked, but this
> makes sense.
> 
> Cc: Jason Baron <jbaron@akamai.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>  include/linux/jump_label.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/include/linux/jump_label.h
> +++ b/include/linux/jump_label.h
> @@ -388,7 +388,7 @@ extern bool ____wrong_branch_error(void)
>  		branch = !arch_static_branch_jump(&(x)->key, true);		\
>  	else									\
>  		branch = ____wrong_branch_error();				\
> -	branch;									\
> +	likely(branch);								\
>  })
>  
>  #define static_branch_unlikely(x)						\
> @@ -400,7 +400,7 @@ extern bool ____wrong_branch_error(void)
>  		branch = arch_static_branch(&(x)->key, false);			\
>  	else									\
>  		branch = ____wrong_branch_error();				\
> -	branch;									\
> +	unlikely(branch);							\
>  })

LOL, it is practically in the name already. :-)

Reviewed-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.