From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbeAYByv (ORCPT ); Wed, 24 Jan 2018 20:54:51 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:54244 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbeAYByt (ORCPT ); Wed, 24 Jan 2018 20:54:49 -0500 Date: Thu, 25 Jan 2018 01:54:41 +0000 From: Al Viro To: Shakeel Butt Cc: Amir Goldstein , Jan Kara , Yang Shi , Michal Hocko , linux-fsdevel , Linux MM , LKML Subject: Re: [PATCH v2] fs: fsnotify: account fsnotify metadata to kmemcg Message-ID: <20180125015441.GS13338@ZenIV.linux.org.uk> References: <20171109135444.znaksm4fucmpuylf@dhcp22.suse.cz> <10924085-6275-125f-d56b-547d734b6f4e@alibaba-inc.com> <20171114093909.dbhlm26qnrrb2ww4@dhcp22.suse.cz> <20171115093131.GA17359@quack2.suse.cz> <20180124103454.ibuqt3njaqbjnrfr@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 24, 2018 at 05:08:27PM -0800, Shakeel Butt wrote: > First, let me apologize, I think I might have led the discussion in > wrong direction by giving one wrong information. The current upstream > kernel, from the syscall context, does not invoke oom-killer when a > memcg hits its limit and fails to reclaim memory, instead ENOMEM is > returned. The memcg oom-killer is only invoked on page faults. However > in a separate effort I do plan to converge the behavior, long > discussion at . Correct me if I'm misinterpreting you, but your rationale in there appears to be along the lines of "userland applications might not be ready to handle -ENOMEM gracefully, so let's hit them with kill -9 instead - that will be handled properly, 'cuz M4G1C!!1!!!!" I must admit that I like the general feel of that idea; may I suggest, as a modest improvement, appending "/usr/local/bin/self-LART\n" to the end of $HOME/.bashrc as well? Killing luser's processes is a nice start, but you have to allow for local policies... -- WWSimonDo?