From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2268geuH8QwLGU7yzgpBpDB4XopPdfGdkHYpYb0L4IUnHnauUpkPdOU5Tt8D5U4bP0yPNfvZ ARC-Seal: i=1; a=rsa-sha256; t=1516872990; cv=none; d=google.com; s=arc-20160816; b=0KuhzDEqnTgXKgfPfLJbQNY8F/vZ+/1Cuc2UOrFO/RHl9om4Rrfx4z8Jo606DeCigl +PAOT1mqBhteLf2A/jgvi6CkhO3rh9Ev6OpTrciiDekBn753889/muC9/YBzaNN75jVG u7CfJyYei3gcZT+ECB8bcV9Ex3u+Cic0NFZdVQ+7i5AFpMkQeUG6TYfPl7u1iR0mQEC9 wZ9huZVgzvcsr/nXyNzL0Eim3Xe4xjBfdSQELS5XCOF/V2UvkW71aBWENsfmsXo3gU4c UoPSOj+LiKCDFI4aAArD9z8ZQsh1g0qa5M9/dgIG9e5IK3uZUVvNPLyK01qY+jC7DLH/ xQOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=GLV5P+QAxiYjDDQXBORCdKo62skHpFA4cTuZeMeWK4o=; b=KUoR/faMbrI3vHXgiRu6ne7JcDSgLb9zN1l7YK3jBHry8km8sIxlIORekQJe93XiF5 NqxbhFRy19dwlfEP8sb/KKJbaFCgkVjYb0ZnBTTjMfSZxNLCCn7J7T3fZNiKzk8EXhiP X9pIcIUaaQFAx00h0FTV1UrL8/glZpQ7xjQAUPqmZlfJL0FBic4hMnIzqSG45/pzbVzF QSmQG4B6dFH+JE+pdFH7S7MxKk1Ec2qbRm4/2ZCR/JRkhEZV83ZqBbhKWbRjLO49svjB 0JYrSSiHM4j8g48oP9Q3KF/iTWCZkSnn0/h5ig6qrgdgmDRFuLQECM/Rb6l+SfeXM46E tmZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=ke2BKjZV; spf=pass (google.com: best guess record for domain of peterz@infradead.org designates 205.233.59.134 as permitted sender) smtp.mailfrom=peterz@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=ke2BKjZV; spf=pass (google.com: best guess record for domain of peterz@infradead.org designates 205.233.59.134 as permitted sender) smtp.mailfrom=peterz@infradead.org Date: Thu, 25 Jan 2018 10:36:23 +0100 From: Peter Zijlstra To: David Woodhouse , Thomas Gleixner , Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, Dave Hansen , Ashok Raj , Tim Chen , Andy Lutomirski , Linus Torvalds , Greg KH , Andrea Arcangeli , Andi Kleen , Arjan Van De Ven , Dan Williams , Paolo Bonzini , Jun Nakajima , Asit Mallick , Jason Baron Subject: Re: [PATCH 07/24] x86,vmx: Fix indirect call Message-ID: <20180125093623.GY2228@hirez.programming.kicks-ass.net> References: <20180123152539.374360046@infradead.org> <20180123152638.395221971@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180123152638.395221971@infradead.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590397845684854555?= X-GMAIL-MSGID: =?utf-8?q?1590556612917930744?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Subject: x86,vmx: Fix indirect call From: Peter Zijlstra Date: Tue Jan 23 14:10:19 CET 2018 Replace indirect call with CALL_NOSPEC. Cc: Paolo Bonzini Signed-off-by: Peter Zijlstra (Intel) --- - now with THUNK_TARGET() arch/x86/kvm/vmx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -9129,14 +9129,14 @@ static void vmx_handle_external_intr(str #endif "pushf\n\t" __ASM_SIZE(push) " $%c[cs]\n\t" - "call *%[entry]\n\t" + CALL_NOSPEC : #ifdef CONFIG_X86_64 [sp]"=&r"(tmp), #endif ASM_CALL_CONSTRAINT : - [entry]"r"(entry), + THUNK_TARGET(entry), [ss]"i"(__KERNEL_DS), [cs]"i"(__KERNEL_CS) );