linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Doug Ledford <dledford@redhat.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	roland@purestorage.com, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] IB/mthca: Fix how mthca_map_user_db() calls gup
Date: Thu, 25 Jan 2018 10:50:48 -0700	[thread overview]
Message-ID: <20180125175048.GG10706@ziepe.ca> (raw)
In-Reply-To: <1516898063.27592.136.camel@redhat.com>

On Thu, Jan 25, 2018 at 11:34:23AM -0500, Doug Ledford wrote:
> > - Should I be wrong about no callers already holding mmap_sem,
> >   I still think calling gup without the mutex makes sense for
> >   improved paralellism. Now, if callers can hold the mmap_sem,
> >   it's wrong to do copy_from_user right before calling mthca_map_user_db.
> 
> So, if I understand you correctly, we (well, you and Al would be more
> correct, we haven't looked into the situation yet, so Mellanox people
> that worked on this in the day might now, or someone taking the time to
> research it could find out) don't have a clear understanding of all the
> conditions this function is called under, and so we actually don't know
> what the best way forward is to fix it?

I looked at it enough to be confident that mthca_map_user_db is never
called with mmap_sem held.

Also pretty confident that mthca_unmap_user_db is never called with
mmap_sem.

So how about just grabbing mmap_sem around the call to get_user_pages
and no other changes?

Jason

  reply	other threads:[~2018-01-25 17:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 20:54 [PATCH] IB/mthca: Fix how mthca_map_user_db() calls gup Davidlohr Bueso
2018-01-25 16:34 ` Doug Ledford
2018-01-25 17:50   ` Jason Gunthorpe [this message]
2018-01-25 18:06     ` Doug Ledford
2018-01-25 18:53       ` Jason Gunthorpe
2018-01-25 19:27         ` Davidlohr Bueso
2018-01-26 15:44           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125175048.GG10706@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=dave@stgolabs.net \
    --cc=dbueso@suse.de \
    --cc=dledford@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=roland@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).