From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbeAZGgj (ORCPT ); Fri, 26 Jan 2018 01:36:39 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:38858 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606AbeAZGgi (ORCPT ); Fri, 26 Jan 2018 01:36:38 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Fri, 26 Jan 2018 15:36:35 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Ingo Molnar , David Ahern , Andi Kleen , Alexander Shishkin , Peter Zijlstra , kernel-team@lge.com Subject: Re: [PATCH 1/2] tools lib symbol: Use strtoul instead of hex2u64 in kallsyms__parse Message-ID: <20180126063635.GB22737@sejong> References: <20180119161103.15035-1-jolsa@kernel.org> <20180119161103.15035-2-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180119161103.15035-2-jolsa@kernel.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 19, 2018 at 05:11:02PM +0100, Jiri Olsa wrote: > Current kallsyms__parse uses hex2u64, which gives > no indication of error. Using strtoul to checkup > on failed attempt to parse the number and stop the > rest of the kallsyms__parse processing early. > > Link: http://lkml.kernel.org/n/tip-djqwni3p6lgctf6o7xhhwpmw@git.kernel.org > Signed-off-by: Jiri Olsa Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/lib/symbol/kallsyms.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tools/lib/symbol/kallsyms.c b/tools/lib/symbol/kallsyms.c > index 914cb8e3d40b..dd5bb1dfd2b6 100644 > --- a/tools/lib/symbol/kallsyms.c > +++ b/tools/lib/symbol/kallsyms.c > @@ -29,6 +29,7 @@ int kallsyms__parse(const char *filename, void *arg, > int line_len, len; > char symbol_type; > char *symbol_name; > + char *endptr; > > line_len = getline(&line, &n, file); > if (line_len < 0 || !line) > @@ -36,9 +37,12 @@ int kallsyms__parse(const char *filename, void *arg, > > line[--line_len] = '\0'; /* \n */ > > - len = hex2u64(line, &start); > + start = strtoul(line, &endptr, 16); > + if (line == endptr) > + continue; > + > + len = endptr - line + 1; > > - len++; > if (len + 2 >= line_len) > continue; > > -- > 2.13.6 >