From: LABBE Corentin <clabbe@baylibre.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] staging: media: remove unused VIDEO_ATOMISP_OV8858 kconfig
Date: Fri, 26 Jan 2018 13:49:39 +0100 [thread overview]
Message-ID: <20180126124939.GC7893@Red> (raw)
In-Reply-To: <20180123182012.GA11384@kroah.com>
On Tue, Jan 23, 2018 at 07:20:12PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe <clabbe@baylibre.com> wrote:
> > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 ("media: staging: atomisp: Remove IMX sensor support")
> > > Lets remove this kconfig option.
> >
> > First of all, I hardly understand how that change is related.
> > Second, did you check Makefile?
>
> I don't see it being used in any Makefile, what file do you see it:
> $ git grep VIDEO_ATOMISP_OV8858
> drivers/staging/media/atomisp/i2c/Kconfig:config VIDEO_ATOMISP_OV8858
>
> So it should be removed.
>
> thanks,
>
Hello
I just see that 3a81c7660f80 left ov8858.c so do you agree that I send a v2 which remove also this file ?
av8858.c is useless without dw9718.c and vcm.c which 3a81c7660f80 removed.
Regards
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-01-26 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 14:37 [PATCH] staging: media: remove unused VIDEO_ATOMISP_OV8858 kconfig Corentin Labbe
2018-01-23 17:31 ` Andy Shevchenko
2018-01-23 18:20 ` Greg Kroah-Hartman
2018-01-26 12:49 ` LABBE Corentin [this message]
2018-01-26 16:25 ` Andy Shevchenko
2018-01-24 8:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126124939.GC7893@Red \
--to=clabbe@baylibre.com \
--cc=andy.shevchenko@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).