From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227wMDMpBZVHHQj7Y0TgDY12Yf5vijWNRfINyXJCN9q4NearfBL0n1Q50bj0SbMoachcfSfP ARC-Seal: i=1; a=rsa-sha256; t=1517247028; cv=none; d=google.com; s=arc-20160816; b=OhGbCR5Fe/LWYgjI+FKQevSSl9vXGBLbYDKfx34/VYlQxmOyv2eA/mM5zCM3a02QEd g51WAW21l49O0HyqUrKuRGOQTpirBfxo8vsNV0bRal3JhtRRGFsVQoAxO5ds0T+lfm7W UspPL7r4YlC8xxnWaUhNAyK6mdp837ob5x/EGn9rnbAzI29Cd1LQZVrUP3LPsPiD5jpc n7RfqtyDmULR2Rdx3nDABcTMK+jwBeUPGmRccU51dRhLKSKffl5IO0kjUGu2OiWH/MD4 /Wo/mNdv2hctWyOvBXnqASJBXlnh6qrvQnQ1y1sAteInMioO2d227Hr+dOeawuGHI/Qf mr1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=SQUFQgT/SLr9fJyqtTYoopMJ9Qq34VmzMPHvggr5dfs=; b=mVHkhPKF7ey3A6zjouhKlYLoyHFoD4dYMX0C3zSwO2eD7DInrfv/iyDk1YhnYfKQAy 9DpPmWYzDq5Uy7dGhiW1QTV22/MT6Vmw7jUYA4MXBbqdmP2e1Zci/Ugj45qbl8+m9sCT SlrbSsIPjP8Rt+74G7aAN8ukG5z30Qnf963hhVa2ZxbRuGdAI6LpfKtjTYIdxC1QUIYC dmKeNHC5NtVKXSBQvwMlhyTymYNLuBUreSvVY5tdsdi7r8ZCWZeW8UvUntcPKSv2CnJw TqwGfxTfgtwiS9YPBSYTG2hFPQss+9qUuiibFW29iklvuuYqmF6JvQcW2uFzs3cdFy1m qvjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jpoimboe@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=jpoimboe@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of jpoimboe@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=jpoimboe@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Date: Mon, 29 Jan 2018 11:30:20 -0600 From: Josh Poimboeuf To: Guenter Roeck Cc: David Woodhouse , Andi Kleen , Paul Turner , LKML , Linus Torvalds , Greg Kroah-Hartman , Tim Chen , Dave Hansen , tglx@linutronix.de, Kees Cook , Rik van Riel , Peter Zijlstra , Andy Lutomirski , Jiri Kosina , gnomes@lxorguk.ukuu.org.uk, x86@kernel.org, thomas.lendacky@amd.com Subject: Re: [v8,02/12] objtool: Allow alternatives to be ignored Message-ID: <20180129173020.hm3fbgcwn6ioso4k@treble> References: <1515707194-20531-3-git-send-email-dwmw@amazon.co.uk> <20180118190931.GA27143@roeck-us.net> <20180118193315.zrrya7qo6kf7pmzp@treble> <20180118194112.GA28449@roeck-us.net> <1516649644.9521.61.camel@infradead.org> <20180122202522.GA29081@roeck-us.net> <20180128210642.xob2win53h2gztak@treble> <20180129171526.GA17121@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180129171526.GA17121@roeck-us.net> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589334210253041473?= X-GMAIL-MSGID: =?utf-8?q?1590948820761915986?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 29, 2018 at 09:15:26AM -0800, Guenter Roeck wrote: > On Sun, Jan 28, 2018 at 03:06:42PM -0600, Josh Poimboeuf wrote: > > On Mon, Jan 22, 2018 at 12:25:22PM -0800, Guenter Roeck wrote: > > > Hi David, > > > > > > On Mon, Jan 22, 2018 at 07:34:04PM +0000, David Woodhouse wrote: > > > > On Thu, 2018-01-18 at 11:41 -0800, Guenter Roeck wrote: > > > > > > > > > > > Not sure, does your gcc have retpolines?  Give me your .o file and I can > > > > > > diagnose it. > > > > > >  > > > > > Yes, it does, only it is the gcc from the Google toolchain which may > > > > > generate different code than the upstream version. > > > > > > > > > > I attached an affected object file. Please let me know if there is anything else > > > > > I can do to help. > > > > Disassembly of section .text.__x86.indirect_thunk: > > > > > > > > 0000000000000000 <__x86.indirect_thunk>: > > > >    0: e8 04 00 00 00        callq  9 <__x86.indirect_thunk+0x9> > > > >    5: f3 90                 pause   > > > >    7: eb fc                 jmp    5 <__x86.indirect_thunk+0x5> > > > >    9: 48 8d 64 24 08        lea    0x8(%rsp),%rsp > > > >    e: c3                    retq    > > > > > > > > That has the old-style CET-incompatible retpoline in a COMDAT section > > > > in the .o file. What compiler options are being used for that? The > > > > kernel should only use retpoline if GCC supports both of > > > > -mindirect-branch=thunk-extern and -mindirect-branch-register, and this > > > > compiler is doing *neither* of those.  > > > > > > It uses "-mindirect-branch=thunk -mindirect-branch-loop=pause > > > -fno-jump-tables", though I don't know if that even exists in > > > upstream gcc (it is the gcc use for Chrome OS builds). I'll pass > > > your feedback to our compiler team. > > > > > > Either case, I think it is less than optimal that objtool crashes > > > with _any_ object code. > > > > I've got a pending fix for this, so that objtool doesn't seg fault, and > > instead prints out a warning: > > > > quirks.o: warning: objtool: efi_delete_dummy_variable()+0x99: unsupported intra-function call > > quirks.o: warning: objtool: If this is a retpoline, please patch it in with alternatives and annotate it with ANNOTATE_NOSPEC_ALTERNATIVE. > > > > The code is here, along with a few more fixes: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jpoimboe/linux.git/log/?h=TODO-objtool-seg-fault > > > > 'objtool: Improve retpoline alternative handling' works for me. Thanks! I'll give you a Reported-and-tested-by: Guenter Roeck -- Josh