From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226QGfEyI6MmXWcLhGZfw13qroilhJxeHeDtijSySw5Khv1bM+6Iu/V/GUyxyjLqWLZQCSuu ARC-Seal: i=1; a=rsa-sha256; t=1517250255; cv=none; d=google.com; s=arc-20160816; b=nhmTUlR8jg8PiR/2Ef89jRD/eLdzFq0qY/DW4tYopDTKC9TmRkeoHzlSwYRasrajDq pvzmp91wwTuyaM1OkYGQyoZl2mL/oeCTgylyj0I0Qk46+JNwwmdjSjL6GBJGFGlsdrxf iY5ZDRDP3LyhYncI7n09lxEqFLlD4gJqMbgCGNIvCY8L0TdEmECd2HNqfEgvg5gbdNMC fraCBfZpQATzxFYLtIkLQTGJZ9yubDhk/Md5WIgaLEChp7cnw/2cjxNWZKGpYbw/zJO4 67Lieh9XGZreAAisfH7kI7sXiCCF9/pTEtPttiyKkOvFc5bwxHB83KTCCfrIlfhOZpO9 rDzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=Y78JsvPjvYoh8se4vqAsyTLnXbTGM1V8g7ciEW9nTm8=; b=xUBvlU0g7OQBDF8GZO40s+CHFEPtBjfmHl0aOWfEduIuZU6uSYuGUNzM+8cVxr337c 3f2K5luvz6+LeH0nUnliNKuYqoHqlCI6nzTdCmjZXolq6lh8MMCH6wzFUHXBS84eu9Lo 7rfkol3UeHidiZK6UnCvl8GJscs7vkBcheUVu+wsGZi6lF3N3hksOuDZ1+/FD8wiFJiF aOYDisUprJfmPpFG72LUE+DxgpaWMuZRuHyWxvPeVHBISuc1JKowixErQtmNjP9Bcfn6 Ow2at2oGwGdN7XiVVRXfd592Xt9Hzeh+YsuWFj0jWsTW3QFPhJwiHaXgPKeqzumhJowe VgXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=gZ9FzMv8; spf=pass (google.com: best guess record for domain of peterz@infradead.org designates 205.233.59.134 as permitted sender) smtp.mailfrom=peterz@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=gZ9FzMv8; spf=pass (google.com: best guess record for domain of peterz@infradead.org designates 205.233.59.134 as permitted sender) smtp.mailfrom=peterz@infradead.org Date: Mon, 29 Jan 2018 19:24:02 +0100 From: Peter Zijlstra To: Josh Poimboeuf Cc: David Woodhouse , Thomas Gleixner , linux-kernel@vger.kernel.org, Dave Hansen , Ashok Raj , Tim Chen , Andy Lutomirski , Linus Torvalds , Greg KH , Andrea Arcangeli , Andi Kleen , Arjan Van De Ven , Dan Williams , Paolo Bonzini , Jun Nakajima , Asit Mallick , Jason Baron Subject: Re: [PATCH 18/35] objtool: Another static block fail Message-ID: <20180129182402.GY2269@hirez.programming.kicks-ass.net> References: <20180118134800.711245485@infradead.org> <20180118140152.536715831@infradead.org> <20180119164229.GR2228@hirez.programming.kicks-ass.net> <20180129180105.khoilqb6cijsw4sh@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180129180105.khoilqb6cijsw4sh@treble> User-Agent: Mutt/1.9.2 (2017-12-15) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcSW1wb3J0YW50Ig==?= X-GMAIL-THRID: =?utf-8?q?1590039860183184435?= X-GMAIL-MSGID: =?utf-8?q?1590952203732245608?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 29, 2018 at 12:01:05PM -0600, Josh Poimboeuf wrote: > On Fri, Jan 19, 2018 at 05:42:29PM +0100, Peter Zijlstra wrote: > > Josh, how would you feel about adding the bits required to make objtool > > a full disassembler? That would make it far easier to visualse the state > > and I don't think its _that_ much more, all the difficult bits are > > already done afaict, all we need is infrastructure to print the already > > fully decoded instruction. > > It sounds interesting, but I have no idea what you mean :-) Can you > elaborate? Well, having had to debug the objtool state, I end up printing sec+offset and then matching up with objdump output. It might be easier to just print annotated assembly in one go. Of course, to make that so, we have this small matter of actually implementing the bits that print the instructions first ;-)