linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Miquel Raynal <miquel.raynal@free-electrons.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: MTD_NAND_MARVELL should depend on HAS_DMA
Date: Tue, 30 Jan 2018 14:56:26 +0100	[thread overview]
Message-ID: <20180130145626.7a108c64@bbrezillon> (raw)
In-Reply-To: <20180130144647.73a44b8d@xps13>

On Tue, 30 Jan 2018 14:46:47 +0100
Miquel Raynal <miquel.raynal@free-electrons.com> wrote:

> Hi Geert,
> 
> On Tue, 30 Jan 2018 14:23:21 +0100
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> 
> > If NO_DMA=y:
> > 
> >     ERROR: "bad_dma_ops" [drivers/mtd/nand/marvell_nand.ko] undefined!
> > 
> > Add a dependency on HAS_DMA to fix this.
> > 
> > Fixes: 02f26ecf8c772751 ("mtd: nand: add reworked Marvell NAND controller driver")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> >  drivers/mtd/nand/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > index e6b8c59f2c0da7c0..736ac887303c88ba 100644
> > --- a/drivers/mtd/nand/Kconfig
> > +++ b/drivers/mtd/nand/Kconfig
> > @@ -328,7 +328,7 @@ config MTD_NAND_MARVELL
> >  	tristate "NAND controller support on Marvell boards"
> >  	depends on PXA3xx || ARCH_MMP || PLAT_ORION || ARCH_MVEBU || \
> >  		   COMPILE_TEST
> > -	depends on HAS_IOMEM
> > +	depends on HAS_IOMEM && HAS_DMA  
> 
> I think this is more a coding issue than a Kconfig issue. AFAIR, none
> of the ARCH_MVEBU SoCs use DMA in conjunction with the NAND controller.
> PXA SoCs may use DMA (NFCv1 only) but this is not a hard requirement and
> the driver is supposed to support PIO mode in all situations.
> 
> Can you please share your setup, the SoC, the configuration,
> maybe also the DT?

I don't think Geert is testing on a real board. He's just enabling
COMPILE_TEST and can then select your driver. Which means you really
need this depends on HAS_DMA.

  reply	other threads:[~2018-01-30 13:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30 13:23 [PATCH] mtd: nand: MTD_NAND_MARVELL should depend on HAS_DMA Geert Uytterhoeven
2018-01-30 13:46 ` Miquel Raynal
2018-01-30 13:56   ` Boris Brezillon [this message]
2018-01-30 13:59     ` Geert Uytterhoeven
2018-01-30 14:05       ` Miquel Raynal
2018-02-12 21:22 ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180130145626.7a108c64@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@free-electrons.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).