From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227HuRos9qev811CZ9BJriIRqqnmRW5pXNHNs7LOtEdZbEjf3CCUjE0QuJ4P/Cs5SPkCIsNs ARC-Seal: i=1; a=rsa-sha256; t=1517328172; cv=none; d=google.com; s=arc-20160816; b=GKF4jLz76LWpsrNWJFrMBHvHkpme5m9mtuzrtGtJjV4E2ILFoi+O8qKQUVO2BdcW+c rDoKNJC8ctXxRzpap5yPYvbpBmAJGC1JlKajWzMI7aF+8+2KWflAk/3qhDW8V7T2c344 r2KUSMwrNQvwF4eeYpMscaX3tGRYs+cNQhyspFrAHhaLGcsAUunlR02nCT2ifzFkwoRc 6HlWkgGwggn1kNqSOVj2GNS0OZMlYDTUZLWsx45h8mmO49mLkA9jK5tn60As1ad8NmJj NlPHejzBDuUe5IIIllVs/QQJ1dtwdS1C0frt1GSgorIcdwbVabEPxiwCoWq63evrCS8V 1q/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:arc-authentication-results; bh=IZw39+9hWVy2PuZSE+ojYXxB4KB7NhDtn4ujiuA3/DU=; b=zYD8iVB12QHCkivhSKlr8TWb23zG2RO7QOoyNXgY3iu1aWafvxJErdVGyQMEd6FlcN gc0vhvcWL7eFnRAEOV4jkpccUT7RAck3M9B7UvCP/l7gqA0gt/MWB5VRtQ2WDG1ZY65S +FHU58HlERE2gtv0sPyL798vFjWLcNDPnW/ksJo8NQrs13xG58AksTscgfPZCPBghpr6 ADUHaPGOQUbmFhdX70nxal22nlSco5g7QdJIWe3mJNzj5QOAEfEoLwh/Gltj4b+r/Roz 6hIwJe8VnZmkQ+Ux2d+u3Rd0I+Gc7rykQtooxBeOxA58E3d1LGwUIAQKIt6ldf4ga2sq 20HQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jpoimboe@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=jpoimboe@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of jpoimboe@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=jpoimboe@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Date: Tue, 30 Jan 2018 10:02:37 -0600 From: Josh Poimboeuf To: Peter Zijlstra Cc: David Woodhouse , Thomas Gleixner , linux-kernel@vger.kernel.org, Dave Hansen , Ashok Raj , Tim Chen , Andy Lutomirski , Linus Torvalds , Greg KH , Andrea Arcangeli , Andi Kleen , Arjan Van De Ven , Dan Williams , Paolo Bonzini , Jun Nakajima , Asit Mallick , Jason Baron Subject: Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls Message-ID: <20180130160237.nimxrlykl4ttsfuk@treble> References: <20180123152539.374360046@infradead.org> <20180123152638.162540737@infradead.org> <20180129183850.b6mjtuz4j5d7wum6@treble> <20180129192108.GR2249@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180129192108.GR2249@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590397845189698377?= X-GMAIL-MSGID: =?utf-8?q?1591033906303962644?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 29, 2018 at 08:21:08PM +0100, Peter Zijlstra wrote: > On Mon, Jan 29, 2018 at 12:38:50PM -0600, Josh Poimboeuf wrote: > > On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > > > Paravirt emits indirect calls which get flagged by objtool retpoline > > > checks, annotate it away because all these indirect calls will be > > > patched out before we start userspace. > > > > There's one condition where this isn't true: the 'noreplace-paravirt' > > cmdline option. I have no idea why that option exists but we should > > consider just removing it. > > Smells like a debug remnant from back when all this patching crap was > new. And yes, that sounds like something that should maybe go away. Esp. > for retpoline builds. Ok, I'll whip up a patch to remove it and see if anybody complains. -- Josh