From: Petr Mladek <pmladek@suse.com>
To: Adam Borowski <kilobyte@angband.pl>
Cc: Kees Cook <keescook@chromium.org>,
"Tobin C. Harding" <me@tobin.cc>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>,
"Roberts, William C" <william.c.roberts@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Laight <David.Laight@aculab.com>,
Randy Dunlap <rdunlap@infradead.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] vsprintf: avoid misleading "(null)" for %px
Date: Wed, 7 Feb 2018 16:03:28 +0100 [thread overview]
Message-ID: <20180207150328.nuk7f76nutq2trcg@pathway.suse.cz> (raw)
In-Reply-To: <20180205205817.72dy7e7xzjcnwmhs@angband.pl>
On Mon 2018-02-05 21:58:17, Adam Borowski wrote:
> On Tue, Feb 06, 2018 at 07:32:32AM +1100, Kees Cook wrote:
> > On Tue, Feb 6, 2018 at 7:15 AM, Tobin C. Harding <me@tobin.cc> wrote:
> > > On Tue, Feb 06, 2018 at 05:57:17AM +1100, Kees Cook wrote:
> > >> On Mon, Feb 5, 2018 at 8:44 PM, Petr Mladek <pmladek@suse.com> wrote:
> > >> > On Sun 2018-02-04 18:45:21, Adam Borowski wrote:
> > >> >> Like %pK already does, print "00000000" instead.
> > >> >>
> > >> >> This confused people -- the convention is that "(null)" means you tried to
> > >> >> dereference a null pointer as opposed to printing the address.
> > >
> > > Leaving aside what is converting to %px. If we consider that using %px
> > > is meant to convey to us that we _really_ want the address, in hex hence
> > > the 'x', then it is not surprising that we will get "00000000"'s for a
> > > null pointer, right? Yes it is different to before but since we are
> > > changing the specifier does this not imply that there may be some
> > > change?
> >
> > I personally prefer 0000s, but if we're going to change this, we need
> > to be aware of the difference.
>
> It's easy to paint this bikeshed any color you guys want to: there's an "if"
> already. My preference is also 0000; NULL would be good, too -- I just
> don't want (null) as that has a special meaning in usual userspace
> implementations; (null) also fits well most other modes of %p as they show
> some object the argument points to. Confusion = wasted debugging time.
> Let's recap:
>
> Currently:
> not-null null
> %pponies object's description (null)
> %px address (null)
> %pK hash hash
>
> I'd propose:
> not-null null
> %pponies object's description (null)
> %px address 00000000
> %pK hash 00000000
It makes sense to me[*], so
Reviewed-by: Petr Mladek <pmladek@suse.com>
It seems that all people agree with this change. But there was also some
confusion. I am going to give it few more days before I push it to
Linus. It means waiting for 4.16-rc3 because I will be without
reliable internet next week. Anyone, feel free to push it faster.
[*] I made some archaeology:
The "(null)" string was added by the commit d97106ab53f812910
("Make %p print '(null)' for NULL pointers").
It was a generic solution to prevent eventual crashes, see
https://lkml.kernel.org/r/1230979341-23029-1-git-send-email-xyzzy@speakeasy.org
>From this point, printing 00000000 for %px looks perfectly fine because
it does not crash.
In fact, it would have made perfect sense to print 00000000 for pure
%p because it did not crash. But nobody has cared about the eventual
confusion yet.
I am not sure if it makes sense to change the pure %p handling
now. Note that printing "(null)" has the advantage that we
get this string instead of the hash ;-)
Best Regards,
Petr
next prev parent reply other threads:[~2018-02-07 15:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 17:45 [PATCH] vsprintf: avoid misleading "(null)" for %px Adam Borowski
2018-02-05 9:44 ` Petr Mladek
2018-02-05 10:03 ` Tobin C. Harding
2018-02-05 15:22 ` Adam Borowski
2018-02-05 16:49 ` Steven Rostedt
2018-02-05 17:36 ` Randy Dunlap
2018-02-05 20:19 ` Tobin C. Harding
2018-02-05 18:57 ` Kees Cook
2018-02-05 20:15 ` Tobin C. Harding
2018-02-05 20:32 ` Kees Cook
2018-02-05 20:58 ` Adam Borowski
2018-02-05 22:22 ` Tobin C. Harding
2018-02-06 18:43 ` Andy Shevchenko
2018-02-07 15:03 ` Petr Mladek [this message]
2018-02-07 15:11 ` Geert Uytterhoeven
2018-02-07 15:41 ` Petr Mladek
2018-02-07 15:48 ` Geert Uytterhoeven
2018-02-08 15:29 ` Andy Shevchenko
2018-02-09 12:03 ` Petr Mladek
2018-02-14 14:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207150328.nuk7f76nutq2trcg@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).