linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
	Al Viro <viro@zeniv.linux.org.uk>,
	stable@vger.kernel.org
Subject: Re: [PATCH] loop: Fix lost writes caused by missing flag
Date: Tue, 13 Feb 2018 12:22:04 -0700	[thread overview]
Message-ID: <20180213192204.GA13682@linux.intel.com> (raw)
In-Reply-To: <20180213145404.GB14657@lst.de>

On Tue, Feb 13, 2018 at 03:54:04PM +0100, Christoph Hellwig wrote:
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> Can you wire up your test cases for blktests?

Is blktests really the right place for this test?  This failure is highly
dependent on the configuration of the filesystem that is holding the file that
we are using for the loopback device.  It doesn't seem like blktests has
support for mount options (dax), etc?

Because of the interaction with the underlying filesystem this seems like a
better fit with xfstests to me, but I don't know if we need to add tests there
because we already have pretty good coverage of loopback device failures.
That's how we found this - this bug causes all these tests to fail:
xfs/074 xfs/078 xfs/216 xfs/217 xfs/250

  reply	other threads:[~2018-02-13 19:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 23:05 [PATCH] loop: Fix lost writes caused by missing flag Ross Zwisler
2018-02-13 14:54 ` Christoph Hellwig
2018-02-13 19:22   ` Ross Zwisler [this message]
2018-02-13 20:52     ` Dan Williams
2018-02-22  3:21 ` Ming Lei
2018-03-09  0:20 ` Ross Zwisler
2018-03-09 15:38   ` Jens Axboe
2018-03-09 15:38     ` Jens Axboe
2018-03-09 16:35       ` Ross Zwisler
2018-03-09 17:19         ` Jens Axboe
2018-03-09 16:38       ` [PATCH] MAINTAINERS: add coverage for drivers/block Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213192204.GA13682@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).