linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCHv2 1/2] zsmalloc: introduce zs_huge_object() function
Date: Wed, 14 Feb 2018 14:52:23 +0900	[thread overview]
Message-ID: <20180214055223.GA508@jagdpanzerIV> (raw)
In-Reply-To: <20180211070539.GA13931@rapoport-lnx>

On (02/11/18 09:05), Mike Rapoport wrote:
[..]
> > +/**
> > + * zs_huge_object() - Test if a compressed object's size is too big for normal
> > + *                    zspool classes and it shall be stored in a huge class.
> 
> I think "is should be stored" is more appropriate
> 
> > + * @sz: Size of the compressed object (in bytes).
> > + *
> > + * The function checks if the object's size falls into huge_class
> > + * area. We must take handle size into account and test the actual
> > + * size we are going to use, because zs_malloc() unconditionally
> > + * adds %ZS_HANDLE_SIZE before it performs %size_class lookup.
> 
>                                             ^ &size_class ;-)

I'm sorry, Mike. Lost in branches/versions and sent out a half baked
version.

	-ss

  reply	other threads:[~2018-02-14  5:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07  9:29 [PATCH 0/2] zsmalloc/zram: drop zram's max_zpage_size Sergey Senozhatsky
2018-02-07  9:29 ` [PATCH 1/2] zsmalloc: introduce zs_huge_object() function Sergey Senozhatsky
2018-02-08 16:30   ` Mike Rapoport
2018-02-09  2:55     ` Sergey Senozhatsky
2018-02-09  4:10       ` Matthew Wilcox
2018-02-09  5:04         ` Sergey Senozhatsky
2018-02-09  5:36         ` Sergey Senozhatsky
2018-02-09  5:48           ` Sergey Senozhatsky
2018-02-09 11:11           ` Mike Rapoport
2018-02-09 12:34             ` Sergey Senozhatsky
2018-02-10  8:23   ` [PATCHv2 " Sergey Senozhatsky
2018-02-11  7:05     ` Mike Rapoport
2018-02-14  5:52       ` Sergey Senozhatsky [this message]
2018-02-14  5:57     ` [PATCHv3 " Sergey Senozhatsky
2018-02-20  1:24       ` Minchan Kim
2018-02-26  5:49         ` Sergey Senozhatsky
2018-02-26  5:58           ` Minchan Kim
2018-02-26  6:50             ` Sergey Senozhatsky
2018-02-26  7:46               ` Minchan Kim
2018-02-26  8:12                 ` Sergey Senozhatsky
2018-02-07  9:29 ` [PATCH 2/2] zram: drop max_zpage_size and use zs_huge_object() Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180214055223.GA508@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).