From: Richard Guy Briggs <rgb@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Eric Paris <eparis@redhat.com>, Steve Grubb <sgrubb@redhat.com>
Subject: Re: [RFC PATCH 2/3] fixup! audit: remove arch_f pointer from struct audit_krule
Date: Thu, 15 Feb 2018 18:12:06 -0500 [thread overview]
Message-ID: <20180215231206.4qlmjpninqedvan3@madcap2.tricolour.ca> (raw)
In-Reply-To: <CAHC9VhRtgzBB0HCNjE--CiYfUSfBq5C2U767BbN=ecRc_dqSZA@mail.gmail.com>
On 2018-02-15 15:43, Paul Moore wrote:
> On Mon, Feb 12, 2018 at 7:29 AM, Richard Guy Briggs <rgb@redhat.com> wrote:
> > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > ---
> > kernel/auditfilter.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> I realize this is an RFC patchset, but considering recent patchsets I
> feel some clarification might be helpful to prevent future delays ...
> when submitting patchsets for merging please do not submit "fixup!"
> patches which fix problems in patches that are submitted earlier in
> the patchset, simply merge/squash the "fixup!" patches before
> submitting.
Yeah, the only reason this is a "fixup!" patch is to clearly show what
remedial step was (surprisingly) needed to fix the bug.
Same with the following "debug!" annotation. Clearly not intended for
upstream to Linus.
> > diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> > index 3343d1c..48dcb59 100644
> > --- a/kernel/auditfilter.c
> > +++ b/kernel/auditfilter.c
> > @@ -221,11 +221,13 @@ static inline int audit_match_class_bits(int class, u32 *mask)
> > static int audit_match_signal(struct audit_entry *entry)
> > {
> > int i;
> > + u32 archval;
> > struct audit_field *arch;
> >
> > for (i = 0; i < entry->rule.field_count; i++)
> > if (entry->rule.fields[i].type == AUDIT_ARCH) {
> > arch = &entry->rule.fields[i];
> > + archval = arch->val;
> > break;
> > }
> >
> > @@ -238,7 +240,7 @@ static int audit_match_signal(struct audit_entry *entry)
> > entry->rule.mask));
> > }
> >
> > - switch(audit_classify_arch(arch->val)) {
> > + switch(audit_classify_arch(archval)) {
> > case 0: /* native */
> > return (audit_match_class_bits(AUDIT_CLASS_SIGNAL,
> > entry->rule.mask));
> > --
> > 1.8.3.1
>
> paul moore
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
next prev parent reply other threads:[~2018-02-15 23:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 12:29 [RFC PATCH 0/3] simplify struct audit_krule reveals bug Richard Guy Briggs
2018-02-12 12:29 ` [RFC PATCH 1/3] audit: remove arch_f pointer from struct audit_krule Richard Guy Briggs
2018-02-15 20:42 ` Paul Moore
2018-11-25 17:11 ` Richard Guy Briggs
2018-11-26 16:37 ` Paul Moore
2018-11-26 19:21 ` Richard Guy Briggs
2018-11-26 21:43 ` Paul Moore
2018-02-12 12:29 ` [RFC PATCH 2/3] fixup! " Richard Guy Briggs
2018-02-15 20:43 ` Paul Moore
2018-02-15 23:12 ` Richard Guy Briggs [this message]
2018-02-12 12:29 ` [RFC PATCH 3/3] debug! " Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215231206.4qlmjpninqedvan3@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).