linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/2] kernel/sofirq: consolidate common code in __tasklet_schedule() + _hi_
Date: Fri, 16 Feb 2018 13:02:37 -0500	[thread overview]
Message-ID: <20180216130237.2a955563@gandalf.local.home> (raw)
In-Reply-To: <20180216175508.vezb3ll32dxvlz4z@linutronix.de>

On Fri, 16 Feb 2018 18:55:09 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:


> > Should we add something like:
> > 
> > 	WARN_ON_ONCE(!in_atomic());
> > 
> > ?  
> 
> Doubt it. this_cpu_ptr() screams already with CONFIG_DEBUG_PREEMPT.

If that's the case then, yeah I agree. I couldn't remember if
this_cpu_ptr() did that or not. I remember having an argument with
Christoph Lameter about whether or not this_cpu_* functions would
complain with preemption off, as some of the use cases were for being
used with preemption enabled. I remember there was some kind of
compromise but didn't remember exactly what that was.

-- Steve

  reply	other threads:[~2018-02-16 18:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 17:20 Consolidate tasklet + tasklet-hi code Sebastian Andrzej Siewior
2018-02-15 17:20 ` [PATCH 1/2] kernel/sofirq: consolidate common code in __tasklet_schedule() + _hi_ Sebastian Andrzej Siewior
2018-02-15 20:07   ` Steven Rostedt
2018-02-15 22:31     ` Julia Cartwright
2018-02-16  8:53     ` Sebastian Andrzej Siewior
2018-02-16 17:31       ` Steven Rostedt
2018-02-16 17:55         ` Sebastian Andrzej Siewior
2018-02-16 18:02           ` Steven Rostedt [this message]
2018-02-16 17:08     ` [PATCH 1/2 v2] " Sebastian Andrzej Siewior
2018-02-20 17:48   ` [kernel/sofirq] ffce8e6f93: BUG:using_smp_processor_id()in_preemptible kernel test robot
2018-02-21 10:50     ` Sebastian Andrzej Siewior
2018-02-15 17:20 ` [PATCH 2/2] kernel/sofirq: consolidate common code in tasklet_action() + tasklet_hi_action() Sebastian Andrzej Siewior
2018-02-15 20:08   ` Steven Rostedt
2018-02-27 16:48 [PATCH v3 00/02] Consolidate tasklet + tasklet-hi code Sebastian Andrzej Siewior
2018-02-27 16:48 ` [PATCH 1/2] kernel/sofirq: consolidate common code in __tasklet_schedule() + _hi_ Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180216130237.2a955563@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).