linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-kbuild@vger.kernel.org
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <mmarek@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>
Subject: [PATCH 1/3] Kconfig: disable PROFILE_ALL_BRANCHES for compile testing
Date: Fri, 16 Feb 2018 22:41:11 +0100	[thread overview]
Message-ID: <20180216214117.1947175-2-arnd@arndb.de> (raw)
In-Reply-To: <20180216214117.1947175-1-arnd@arndb.de>

This can easily double the time for compiling a driver but does not
provide any benefit for the compile tester, so it's better left disabled.

In addition, any 'inline' function that is not also 'static' and that
contains an 'if' causes a warning like

include/linux/string.h:212:2: note: in expansion of macro 'if'
  if (strscpy(p, q, p_size < q_size ? p_size : q_size) < 0)
  ^~
include/linux/compiler.h:162:4: warning: '______f' is static but declared in inline function 'strcpy' which is not static

without this patch, and I could not come up with a nice fix for that.
In combination with my patch to always enable 'CONFIG_COMPILE_TEST'
during 'randconfig' builds, we can at least hide these warnings for
most users.

Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/trace/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 434c840e2d82..faaf687b13b1 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -345,6 +345,7 @@ config PROFILE_ANNOTATED_BRANCHES
 config PROFILE_ALL_BRANCHES
 	bool "Profile all if conditionals"
 	select TRACE_BRANCH_PROFILING
+	depends on !COMPILE_TEST
 	help
 	  This tracer profiles all branch conditions. Every if ()
 	  taken in the kernel is recorded whether it hit or miss.
-- 
2.9.0

  reply	other threads:[~2018-02-16 21:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 21:41 [PATCH 0/3] fixing the last failures in randconfig builds Arnd Bergmann
2018-02-16 21:41 ` Arnd Bergmann [this message]
2018-02-16 22:03   ` [PATCH 1/3] Kconfig: disable PROFILE_ALL_BRANCHES for compile testing Steven Rostedt
2018-02-16 22:14     ` Arnd Bergmann
2018-02-16 22:40       ` Arnd Bergmann
2018-02-16 22:50         ` Steven Rostedt
2018-02-17 13:32       ` Greg Kroah-Hartman
2018-02-20  9:32   ` Masahiro Yamada
2018-02-16 21:41 ` [PATCH 2/3] Kconfig: improve handling for all{rand,yes,no,}.config fragments Arnd Bergmann
2018-02-20  9:26   ` Masahiro Yamada
2018-02-20  9:59     ` Arnd Bergmann
2018-02-20 17:04       ` Masahiro Yamada
2018-02-21 16:57         ` Arnd Bergmann
2018-02-22 17:27           ` Masahiro Yamada
2018-02-23  4:13           ` Masahiro Yamada
2018-02-16 21:41 ` [PATCH 3/3] Kconfig: add a default allrandom.config Arnd Bergmann
2018-02-20  9:16   ` Masahiro Yamada
2018-02-20 11:11     ` Arnd Bergmann
2018-02-20 16:51       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180216214117.1947175-2-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=yamada.masahiro@socionext.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).