From: David Miller <davem@davemloft.net>
To: fthain@telegraphics.com.au
Cc: netdev@vger.kernel.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu
Date: Mon, 19 Feb 2018 23:15:23 -0500 (EST) [thread overview]
Message-ID: <20180219.231523.2226814242777657736.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.21.1802201108100.8@nippy.intranet>
From: Finn Thain <fthain@telegraphics.com.au>
Date: Tue, 20 Feb 2018 11:42:26 +1100 (AEDT)
> If there was an unused variables I would happily remove that too but the
> 'version' string is not unused. The etherh.c and mac8390.c files both
> include "lib8390.c" and in there you'll find the 'version' string used in
> ethdev_setup().
My bad, thanks for being so patient with me :)
next prev parent reply other threads:[~2018-02-20 4:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 2:39 [PATCH net 0/4] Fixes, cleanup and modernization for 8390 ethernet drivers Finn Thain
2018-02-19 2:39 ` [PATCH net 2/4] net/8390: Fix msg_enable patch snafu Finn Thain
2018-02-19 19:11 ` David Miller
2018-02-19 22:01 ` Finn Thain
2018-02-19 23:43 ` David Miller
2018-02-20 0:42 ` Finn Thain
2018-02-20 4:15 ` David Miller [this message]
2018-02-21 19:14 ` David Miller
2018-02-19 2:39 ` [PATCH net 3/4] net/mac8390: Convert to nubus_driver Finn Thain
2018-02-19 2:39 ` [PATCH net 1/4] net/8390: Remove redundant make dependencies Finn Thain
2018-02-19 2:47 ` Greg Ungerer
2018-02-19 2:39 ` [PATCH net 4/4] net/mac8390: Fix log messages Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219.231523.2226814242777657736.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).