From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753404AbeBSRni (ORCPT ); Mon, 19 Feb 2018 12:43:38 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:43450 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753267AbeBSRng (ORCPT ); Mon, 19 Feb 2018 12:43:36 -0500 X-Google-Smtp-Source: AH8x227obfua/KWjMjOvB3SSoFS1yQPNbIYiOhT/YHKQa1joZVbZnnQ9+YjzEX9I02ucLc78cnP49w== Date: Mon, 19 Feb 2018 23:13:28 +0530 From: Manivannan Sadhasivam To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: linus.walleij@linaro.org, robh+dt@kernel.org, liuwei@actions-semi.com, mp-cs@actions-semi.com, 96boards@ucrobotics.com, devicetree@vger.kernel.org, daniel.thompson@linaro.org, amit.kucheria@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] arm64: dts: actions: Add S900 gpio nodes Message-ID: <20180219174328.lcrzbj6oswvmaxmt@linaro.org> References: <20180217204433.3095-1-manivannan.sadhasivam@linaro.org> <20180217204433.3095-7-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas, On Sat, Feb 17, 2018 at 10:08:37PM +0100, Andreas Färber wrote: > Am 17.02.2018 um 21:44 schrieb Manivannan Sadhasivam: > > Add gpio nodes for Actions Semi S900 SoC. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > arch/arm64/boot/dts/actions/s900.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi > > index 0156483f0f4d..e359509ad9d3 100644 > > --- a/arch/arm64/boot/dts/actions/s900.dtsi > > +++ b/arch/arm64/boot/dts/actions/s900.dtsi > > @@ -180,6 +180,13 @@ > > clocks = <&cmu CLK_GPIO>; > > }; > > > > + gpio: gpio@e01b0000 { > > + compatible = "actions,s900-gpio"; > > + reg = <0x0 0xe01b0000 0x0 0x1000>; > > + gpio-controller; > > Same as the bindings example, this is lacking gpio-ranges. > Sure, will add it. > https://github.com/afaerber/linux/commit/f4526bbacd75d014a69e6e3ff051638589ee71a3 > > Also why have only one node? That forces the information about GPIO > banks into the driver rather than into the DT. > In next revision all banks will be made as individual gpio-controllers, which will in turn have individual nodes. The justification was already provided in gpio driver patch. Thanks, Mani > > + #gpio-cells = <2>; > > + }; > > + > > timer: timer@e0228000 { > > compatible = "actions,s900-timer"; > > reg = <0x0 0xe0228000 0x0 0x8000>; > > Regards, > Andreas > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg)