From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932198AbeBSUnf (ORCPT ); Mon, 19 Feb 2018 15:43:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:49042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932096AbeBSUnd (ORCPT ); Mon, 19 Feb 2018 15:43:33 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 182A620C51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Mon, 19 Feb 2018 14:43:31 -0600 From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Jayachandran Nair , Lorenzo Pieralisi , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Alex Williamson , Robert Richter , Tom Vaden , Mika Westerberg , George Cherian Subject: Re: [PATCH v1 0/2] PCI: Probe for reset support earlier Message-ID: <20180219204331.GB48133@bhelgaas-glaptop.roam.corp.google.com> References: <20180216224213.67295.2251.stgit@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180216224213.67295.2251.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 16, 2018 at 04:50:03PM -0600, Bjorn Helgaas wrote: > The PCI core currently uses a late_initcall to probe each device for > whether it supports reset. This is dangerous because a driver may have > already claimed the device by this point, and the PCI core should not > interfere with the driver by touching the device on its own. > > These patches move the probe to be earlier, during enumeration, before a > driver has a chance to claim the device. > > --- > > Bjorn Helgaas (2): > PCI: Probe for device reset support before driver claim > PCI: Remove redundant probes for device reset support > > > drivers/pci/pci-sysfs.c | 3 +-- > drivers/pci/pci.c | 15 ++++++--------- > drivers/pci/probe.c | 3 +++ > 3 files changed, 10 insertions(+), 11 deletions(-) Applied both to pci/virtualization with Rafael's reviewed-by (and update to comment to s/D3hot/D3/) for v4.17.