From: kbuild test robot <lkp@intel.com>
To: Maciej Purski <m.purski@samsung.com>
Cc: kbuild-all@01.org, linux-media@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, David Airlie <airlied@linux.ie>,
Michael Turquette <mturquette@baylibre.com>,
Kamil Debski <kamil@wypas.org>,
Maciej Purski <m.purski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Thibault Saunier <thibault.saunier@osg.samsung.com>,
Russell King <linux@armlinux.org.uk>,
Krzysztof Kozlowski <krzk@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Hoegeun Kwon <hoegeun.kwon@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jeongtae Park <jtp.park@samsung.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Hans Verkuil <hansverk@cisco.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 8/8] [media] s5p-mfc: Use clk bulk API
Date: Tue, 20 Feb 2018 09:56:35 +0800 [thread overview]
Message-ID: <201802200934.6OQHn9ra%fengguang.wu@intel.com> (raw)
In-Reply-To: <1519055046-2399-9-git-send-email-m.purski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 2522 bytes --]
Hi Maciej,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16-rc2 next-20180219]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Maciej-Purski/Use-clk-bulk-API-in-exynos5433-drivers/20180220-054431
base: git://linuxtv.org/media_tree.git master
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64
All warnings (new ones prefixed by >>):
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c: In function 's5p_mfc_init_pm':
>> drivers/media/platform/s5p-mfc/s5p_mfc_pm.c:39:7: warning: passing argument 3 of 'devm_clk_bulk_alloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
pm->clk_names);
^~
In file included from drivers/media/platform/s5p-mfc/s5p_mfc_pm.c:13:0:
include/linux/clk.h:654:37: note: expected 'const char **' but argument is of type 'const char * const*'
static inline struct clk_bulk_data *devm_clk_bulk_alloc(struct device *dev,
^~~~~~~~~~~~~~~~~~~
vim +39 drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
24
25 int s5p_mfc_init_pm(struct s5p_mfc_dev *dev)
26 {
27 int ret;
28
29 pm = &dev->pm;
30 p_dev = dev;
31
32 pm->num_clocks = dev->variant->num_clocks;
33 pm->clk_names = dev->variant->clk_names;
34 pm->device = &dev->plat_dev->dev;
35 pm->clock_gate = NULL;
36
37 /* clock control */
38 pm->clocks = devm_clk_bulk_alloc(pm->device, pm->num_clocks,
> 39 pm->clk_names);
40 if (IS_ERR(pm->clocks))
41 return PTR_ERR(pm->clocks);
42
43 ret = devm_clk_bulk_get(pm->device, pm->num_clocks, pm->clocks);
44 if (ret < 0)
45 return ret;
46
47 if (dev->variant->use_clock_gating)
48 pm->clock_gate = pm->clocks[0].clk;
49
50 pm_runtime_enable(pm->device);
51 atomic_set(&clk_ref, 0);
52 return 0;
53 }
54
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53401 bytes --]
prev parent reply other threads:[~2018-02-20 1:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180219154456eucas1p178a82b3bb643028dc7c99ccca9c6eaca@eucas1p1.samsung.com>
2018-02-19 15:43 ` [PATCH 0/8] Use clk bulk API in exynos5433 drivers Maciej Purski
[not found] ` <CGME20180219154456eucas1p15f4073beaf61312238f142f217a8bb3c@eucas1p1.samsung.com>
2018-02-19 15:43 ` [PATCH 1/8] clk: Add clk_bulk_alloc functions Maciej Purski
2018-02-19 16:29 ` Robin Murphy
2018-02-20 9:36 ` Marek Szyprowski
2018-02-20 14:19 ` Robin Murphy
2018-03-15 22:55 ` Stephen Boyd
2018-02-19 18:22 ` Emil Velikov
[not found] ` <CGME20180219154457eucas1p163264992903698a8878aa5abbc8aa17b@eucas1p1.samsung.com>
2018-02-19 15:44 ` [PATCH 2/8] media: s5p-jpeg: Use bulk clk API Maciej Purski
2018-02-20 0:22 ` kbuild test robot
[not found] ` <CGME20180219154458eucas1p1b4e728757e78f3d5dde5c9aa565a5d20@eucas1p1.samsung.com>
2018-02-19 15:44 ` [PATCH 3/8] drm/exynos/decon: Use clk bulk API Maciej Purski
[not found] ` <CGME20180219154459eucas1p147525b88de5d34f646aa25cb8de1f1d0@eucas1p1.samsung.com>
2018-02-19 15:44 ` [PATCH 4/8] drm/exynos/dsi: " Maciej Purski
2018-02-20 1:39 ` kbuild test robot
[not found] ` <CGME20180219154500eucas1p25e9f3bf44901cb2bbe9720cdc5bdd855@eucas1p2.samsung.com>
2018-02-19 15:44 ` [PATCH 5/8] drm/exynos: mic: " Maciej Purski
[not found] ` <CGME20180219154501eucas1p1e16a883d2eb0c8a99bafce5d71656066@eucas1p1.samsung.com>
2018-02-19 15:44 ` [PATCH 6/8] drm/exynos/hdmi: " Maciej Purski
[not found] ` <CGME20180219154502eucas1p20e8daf3edc6737817f8d62db5a2099f2@eucas1p2.samsung.com>
2018-02-19 15:44 ` [PATCH 7/8] [media] exynos-gsc: " Maciej Purski
2018-02-19 22:38 ` kbuild test robot
[not found] ` <CGME20180219154503eucas1p1c8893411994bd1152d0ce5b386118416@eucas1p1.samsung.com>
2018-02-19 15:44 ` [PATCH 8/8] [media] s5p-mfc: " Maciej Purski
2018-02-20 1:56 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201802200934.6OQHn9ra%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=airlied@linux.ie \
--cc=andrzej.p@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hansverk@cisco.com \
--cc=hoegeun.kwon@samsung.com \
--cc=jacek.anaszewski@gmail.com \
--cc=javier@osg.samsung.com \
--cc=jtp.park@samsung.com \
--cc=kamil@wypas.org \
--cc=kbuild-all@01.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.purski@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=thibault.saunier@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).