From: jacopo mondi <jacopo@jmondi.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/15] soc: renesas: Add R-Car M3-N support
Date: Tue, 20 Feb 2018 11:10:04 +0100 [thread overview]
Message-ID: <20180220101004.GD7203@w540> (raw)
In-Reply-To: <CAMuHMdU-pYNwjrXSR7j2kNkJSYsKd=0Kf0Tzq5LHpwA7p4_9MA@mail.gmail.com>
Hi Geert,
On Wed, Feb 14, 2018 at 01:48:27PM +0100, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> Thanks for your patch!
>
> On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi
> <jacopo+renesas@jmondi.org> wrote:
> > Add support for R-Car M3-N (r8a77965) power areas and reset.
> > M3-N power areas are identical to M3-W ones, so just copy and rename
> > them.
>
> They are not identical:
> - M3-N does not have the CA53-related areas,
> - M3-W does not have A3VP,
> - M3-N does not have A2VC0 (M3-W also doesn't, according to latest
> datasheet?).
>
> The datasheet also mentions A3SH, without further info about the register
> block. I think we need to bring this up with Renesas.
>
> > .../bindings/power/renesas,rcar-sysc.txt | 1 +
> > .../devicetree/bindings/reset/renesas,rst.txt | 1 +
> > drivers/soc/renesas/Kconfig | 9 ++++--
> > drivers/soc/renesas/Makefile | 1 +
> > drivers/soc/renesas/r8a77965-sysc.c | 37 ++++++++++++++++++++++
> > drivers/soc/renesas/rcar-rst.c | 1 +
> > drivers/soc/renesas/rcar-sysc.c | 3 ++
> > drivers/soc/renesas/rcar-sysc.h | 1 +
> > drivers/soc/renesas/renesas-soc.c | 8 +++++
> > include/dt-bindings/power/r8a77965-sysc.h | 31 ++++++++++++++++++
> > 10 files changed, 91 insertions(+), 2 deletions(-)
> > create mode 100644 drivers/soc/renesas/r8a77965-sysc.c
> > create mode 100644 include/dt-bindings/power/r8a77965-sysc.h
>
> The maintainer may ask you to split this patch by functionality...
>
> > --- /dev/null
> > +++ b/drivers/soc/renesas/r8a77965-sysc.c
> > @@ -0,0 +1,37 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Renesas R-Car M3-N System Controller
> > + * Copyright (C) 2018 Jacopo Mondi <jacopo+renesas@jmondi.org>
> > + *
> > + * Based on Renesas R-Car M3-W System Controller
> > + * Copyright (C) 2016 Glider bvba
> > + */
> > +
> > +#include <linux/bug.h>
> > +#include <linux/kernel.h>
> > +
> > +#include <dt-bindings/power/r8a77965-sysc.h>
> > +
> > +#include "rcar-sysc.h"
> > +
> > +static const struct rcar_sysc_area r8a77965_areas[] __initconst = {
> > + { "always-on", 0, 0, R8A77965_PD_ALWAYS_ON, -1, PD_ALWAYS_ON },
> > + { "ca57-scu", 0x1c0, 0, R8A77965_PD_CA57_SCU, R8A77965_PD_ALWAYS_ON,
> > + PD_SCU },
> > + { "ca57-cpu0", 0x80, 0, R8A77965_PD_CA57_CPU0, R8A77965_PD_CA57_SCU,
> > + PD_CPU_NOCR },
> > + { "ca57-cpu1", 0x80, 1, R8A77965_PD_CA57_CPU1, R8A77965_PD_CA57_SCU,
> > + PD_CPU_NOCR },
> > + { "cr7", 0x240, 0, R8A77965_PD_CR7, R8A77965_PD_ALWAYS_ON },
> > + { "a3vc", 0x380, 0, R8A77965_PD_A3VC, R8A77965_PD_ALWAYS_ON },
> > + { "a2vc0", 0x3c0, 0, R8A77965_PD_A2VC0, R8A77965_PD_A3VC },
>
> M3-N (and M3-W) does not have A2VC0?
Why do I still see that power area listed in latest renesas-drivers for
M3-W? Are there patch pendings for that?
I'll remove it anyway for M3-N.
Thanks
j
>
> > + { "a2vc1", 0x3c0, 1, R8A77965_PD_A2VC1, R8A77965_PD_A3VC },
> > + { "3dg-a", 0x100, 0, R8A77965_PD_3DG_A, R8A77965_PD_ALWAYS_ON },
> > + { "3dg-b", 0x100, 1, R8A77965_PD_3DG_B, R8A77965_PD_3DG_A },
> > + { "a3ir", 0x180, 0, R8A77965_PD_A3IR, R8A77965_PD_ALWAYS_ON },
>
> A3VP is missing?
>
> > +};
> > +
> > +const struct rcar_sysc_info r8a77965_sysc_info __initconst = {
> > + .areas = r8a77965_areas,
> > + .num_areas = ARRAY_SIZE(r8a77965_areas),
> > +};
>
> > --- /dev/null
> > +++ b/include/dt-bindings/power/r8a77965-sysc.h
> > @@ -0,0 +1,31 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Copyright (C) 2018 Jacopo Mondi <jacopo+renesas@jmondi.org>
> > + * Copyright (C) 2016 Glider bvba
> > + */
> > +
> > +#ifndef __DT_BINDINGS_POWER_R8A77965_SYSC_H__
> > +#define __DT_BINDINGS_POWER_R8A77965_SYSC_H__
> > +
> > +/*
> > + * These power domain indices match the numbers of the interrupt bits
> > + * representing the power areas in the various Interrupt Registers
> > + * (e.g. SYSCISR, Interrupt Status Register)
> > + */
> > +
> > +#define R8A77965_PD_CA57_CPU0 0
> > +#define R8A77965_PD_CA57_CPU1 1
> > +#define R8A77965_PD_A3VP 9
> > +#define R8A77965_PD_CA57_SCU 12
> > +#define R8A77965_PD_CR7 13
> > +#define R8A77965_PD_A3VC 14
> > +#define R8A77965_PD_3DG_A 17
> > +#define R8A77965_PD_3DG_B 18
> > +#define R8A77965_PD_A3IR 24
> > +#define R8A77965_PD_A2VC0 25
>
> M3-N (and M3-W) does not have A2VC0?
>
> > +#define R8A77965_PD_A2VC1 26
> > +
> > +/* Always-on power area */
> > +#define R8A77965_PD_ALWAYS_ON 32
> > +
> > +#endif /* __DT_BINDINGS_POWER_R8A77965_SYSC_H__ */
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2018-02-20 10:10 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 9:45 [PATCH 00/15] R-Car M3-N initial support Jacopo Mondi
2018-02-13 9:45 ` [PATCH 01/15] Documentation: devicetree: R-Car M3-N SoC DT bindings Jacopo Mondi
2018-02-14 10:01 ` Simon Horman
2018-02-19 2:52 ` Rob Herring
2018-02-19 9:19 ` Simon Horman
2018-02-14 10:36 ` Geert Uytterhoeven
2018-02-13 9:45 ` [PATCH 02/15] clk: renesas: cpg-msr: Add support for R-Car M3-N Jacopo Mondi
2018-02-13 11:48 ` Kieran Bingham
2018-02-14 11:03 ` Geert Uytterhoeven
2018-02-15 15:31 ` Simon Horman
2018-02-16 9:03 ` Geert Uytterhoeven
2018-02-19 2:53 ` Rob Herring
2018-02-13 9:45 ` [PATCH 03/15] soc: renesas: Add R-Car M3-N support Jacopo Mondi
2018-02-14 12:48 ` Geert Uytterhoeven
2018-02-15 15:34 ` Simon Horman
2018-02-20 10:10 ` jacopo mondi [this message]
2018-02-13 9:45 ` [PATCH 04/15] pinctrl: sh-pfc: Initial " Jacopo Mondi
2018-02-14 13:37 ` Geert Uytterhoeven
2018-02-14 13:53 ` jacopo mondi
2018-02-14 14:25 ` Geert Uytterhoeven
2018-02-19 2:57 ` Rob Herring
2018-02-13 9:45 ` [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x " Jacopo Mondi
2018-02-14 13:58 ` Geert Uytterhoeven
2018-02-14 21:22 ` Philippe Ombredanne
2018-02-15 15:38 ` Simon Horman
2018-02-16 9:20 ` Geert Uytterhoeven
2018-02-16 9:36 ` Geert Uytterhoeven
2018-02-13 9:45 ` [PATCH 06/15] Documentation: devicetree: dma: Add r8a77965 dmac Jacopo Mondi
2018-02-14 13:59 ` Geert Uytterhoeven
2018-02-15 15:39 ` Simon Horman
2018-02-15 15:56 ` Simon Horman
2018-02-16 9:01 ` Geert Uytterhoeven
2018-02-16 13:40 ` Simon Horman
2018-02-19 2:58 ` Rob Herring
2018-02-13 9:45 ` [PATCH 07/15] ARM64: dts: r8a77965: Add dmac device nods Jacopo Mondi
2018-02-14 14:08 ` Geert Uytterhoeven
2018-02-13 9:45 ` [PATCH 08/15] Documentation: devicetree: renesas,sci: Add r8a77965 Jacopo Mondi
2018-02-14 14:03 ` Geert Uytterhoeven
2018-02-15 15:47 ` Simon Horman
2018-02-19 2:59 ` Rob Herring
2018-02-13 9:45 ` [PATCH 09/15] pinctrl: sh-pfc: r8a77965: Add SCIFs groups/functions Jacopo Mondi
2018-02-14 14:42 ` Geert Uytterhoeven
2018-02-13 9:45 ` [PATCH 10/15] ARM64: dts: r8a77965: Add SCIF device nodes Jacopo Mondi
2018-02-14 14:13 ` Geert Uytterhoeven
2018-02-13 9:45 ` [PATCH 11/15] gpio: rcar: Add R-Car M3-N compatible string Jacopo Mondi
2018-02-14 14:05 ` Geert Uytterhoeven
2018-02-20 13:35 ` jacopo mondi
2018-02-20 13:40 ` Geert Uytterhoeven
2018-02-13 9:45 ` [PATCH 12/15] ARM64: dts: r8a77965: Add GPIO nodes Jacopo Mondi
2018-02-14 14:10 ` Geert Uytterhoeven
2018-02-13 9:46 ` [PATCH 13/15] Documentation: devicetree: ravb: Add r8a77965 Jacopo Mondi
2018-02-14 14:06 ` Geert Uytterhoeven
2018-02-14 15:02 ` Sergei Shtylyov
2018-02-15 15:45 ` Simon Horman
2018-02-19 3:01 ` Rob Herring
2018-02-13 9:46 ` [PATCH 14/15] pinctrl: sh-pfc: r8a77965: Add EtherAVB groups/functions Jacopo Mondi
2018-02-14 14:47 ` Geert Uytterhoeven
2018-02-13 9:46 ` [PATCH 15/15] ARM64: dts: r8a77965: Add EtherAVB device node Jacopo Mondi
2018-02-14 14:48 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220101004.GD7203@w540 \
--to=jacopo@jmondi.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).