From: Michal Hocko <mhocko@kernel.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Dan Rue <dan.rue@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API
Date: Wed, 21 Feb 2018 19:54:25 +0100 [thread overview]
Message-ID: <20180221185425.GK2231@dhcp22.suse.cz> (raw)
In-Reply-To: <840f8c4f-0994-fa7d-0b8d-ad2c8d77c67d@oracle.com>
On Wed 21-02-18 09:59:40, Mike Kravetz wrote:
> On 02/21/2018 02:01 AM, Michal Hocko wrote:
> > On Wed 21-02-18 10:55:26, Michal Hocko wrote:
> > Hmm, I guess I can see it. Does the following help?
> > ---
> > diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> > index 7c204e3d132b..a963f2034dfc 100644
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -1583,7 +1583,7 @@ static struct page *alloc_surplus_huge_page(struct hstate *h, gfp_t gfp_mask,
> > page = NULL;
> > } else {
> > h->surplus_huge_pages++;
> > - h->nr_huge_pages_node[page_to_nid(page)]++;
> > + h->surplus_huge_pages_node[page_to_nid(page)]++;
> > }
> >
> > out_unlock:
>
> I thought we had this corrected in a previous version of the patch.
> My apologies for not looking more closely at this version.
I must have screwed up when rebasing. I remember I was splitting this
patch...
> FWIW,
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-02-21 18:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 9:32 [PATCH 0/6] mm, hugetlb: allocation API and migration improvements Michal Hocko
2018-01-03 9:32 ` [PATCH 1/6] mm, hugetlb: unify core page allocation accounting and initialization Michal Hocko
2018-01-03 9:32 ` [PATCH 2/6] mm, hugetlb: integrate giga hugetlb more naturally to the allocation path Michal Hocko
2018-01-03 9:32 ` [PATCH 3/6] mm, hugetlb: do not rely on overcommit limit during migration Michal Hocko
2018-01-03 9:32 ` [PATCH 4/6] mm, hugetlb: get rid of surplus page accounting tricks Michal Hocko
2018-01-03 9:32 ` [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API Michal Hocko
2018-02-21 4:24 ` Dan Rue
2018-02-21 9:55 ` Michal Hocko
2018-02-21 10:01 ` Michal Hocko
2018-02-21 16:19 ` Dan Rue
2018-02-21 18:52 ` Michal Hocko
2018-02-21 19:05 ` Dan Rue
2018-02-21 17:59 ` Mike Kravetz
2018-02-21 18:54 ` Michal Hocko [this message]
2018-02-21 19:14 ` [PATCH] hugetlb: fix surplus pages accounting Michal Hocko
2018-01-03 9:32 ` [PATCH 6/6] hugetlb, mempolicy: fix the mbind hugetlb migration Michal Hocko
2018-01-04 0:05 ` [PATCH 0/6] mm, hugetlb: allocation API and migration improvements Andrew Morton
2018-01-04 7:32 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221185425.GK2231@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.rue@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).