From: Peter Zijlstra <peterz@infradead.org>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf annotate: Support to display the LBR data in tui mode
Date: Fri, 23 Feb 2018 09:25:00 +0100 [thread overview]
Message-ID: <20180223082500.GT25181@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1519396558-23397-1-git-send-email-yao.jin@linux.intel.com>
On Fri, Feb 23, 2018 at 10:35:58PM +0800, Jin Yao wrote:
> Unlike the perf report interactive annotate mode, the perf annotate
> doesn't display the LBR data.
>
> perf record -b ...
> perf annotate function
>
> It should show IPC/cycle, but it doesn't.
There is far more than IPC/cycle for the LBR data, so this Changelog is
misleading.
Also, I think that this patch goes the wrong way, we should reduce the
divergence of the various modes, not make it worse.
next prev parent reply other threads:[~2018-02-23 8:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 14:35 [PATCH] perf annotate: Support to display the LBR data in tui mode Jin Yao
2018-02-23 8:25 ` Peter Zijlstra [this message]
2018-02-23 9:08 ` Jin, Yao
2018-02-23 15:29 ` Arnaldo Carvalho de Melo
2018-02-23 16:59 ` Peter Zijlstra
2018-02-23 17:02 ` Andi Kleen
2018-02-27 9:38 ` [PATCH v2] perf annotate: Support to display the IPC/Cycle " Jin Yao
2018-03-08 5:22 ` Jin, Yao
2018-03-08 13:12 ` Arnaldo Carvalho de Melo
2018-03-09 8:57 ` [tip:perf/core] perf annotate: Support to display the IPC/Cycle in TUI mode tip-bot for Jin Yao
2018-02-24 1:40 ` [PATCH] perf annotate: Support to display the LBR data in tui mode Jin, Yao
2018-02-26 13:57 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223082500.GT25181@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).