From: kbuild test robot <lkp@intel.com>
To: KarimAllah Ahmed <karahmed@amazon.de>
Cc: kbuild-all@01.org, x86@kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, hpa@zytor.com, jmattson@google.com,
mingo@redhat.com, pbonzini@redhat.com, rkrcmar@redhat.com,
tglx@linutronix.de, KarimAllah Ahmed <karahmed@amazon.de>
Subject: Re: [PATCH 03/10] X86/nVMX: Update the PML table without mapping and unmapping the page
Date: Fri, 23 Feb 2018 10:02:07 +0800 [thread overview]
Message-ID: <201802230930.RXBHE4wM%fengguang.wu@intel.com> (raw)
In-Reply-To: <1519235241-6500-4-git-send-email-karahmed@amazon.de>
[-- Attachment #1: Type: text/plain, Size: 2361 bytes --]
Hi KarimAllah,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/auto-latest]
[also build test WARNING on v4.16-rc2 next-20180222]
[cannot apply to kvm/linux-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/KarimAllah-Ahmed/KVM-X86-Handle-guest-memory-that-does-not-have-a-struct-page/20180223-064826
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
arch/x86/kvm/vmx.c: In function 'vmx_write_pml_buffer':
>> arch/x86/kvm/vmx.c:11951:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
dst = (gpa_t)(((u64 *)vmcs12->pml_address) + vmcs12->guest_pml_index);
^
>> arch/x86/kvm/vmx.c:11951:9: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
dst = (gpa_t)(((u64 *)vmcs12->pml_address) + vmcs12->guest_pml_index);
^
vim +11951 arch/x86/kvm/vmx.c
11926
11927 static int vmx_write_pml_buffer(struct kvm_vcpu *vcpu)
11928 {
11929 struct vmcs12 *vmcs12;
11930 struct vcpu_vmx *vmx = to_vmx(vcpu);
11931 gpa_t gpa, dst;
11932
11933 if (is_guest_mode(vcpu)) {
11934 WARN_ON_ONCE(vmx->nested.pml_full);
11935
11936 /*
11937 * Check if PML is enabled for the nested guest.
11938 * Whether eptp bit 6 is set is already checked
11939 * as part of A/D emulation.
11940 */
11941 vmcs12 = get_vmcs12(vcpu);
11942 if (!nested_cpu_has_pml(vmcs12))
11943 return 0;
11944
11945 if (vmcs12->guest_pml_index >= PML_ENTITY_NUM) {
11946 vmx->nested.pml_full = true;
11947 return 1;
11948 }
11949
11950 gpa = vmcs_read64(GUEST_PHYSICAL_ADDRESS) & ~0xFFFull;
11951 dst = (gpa_t)(((u64 *)vmcs12->pml_address) + vmcs12->guest_pml_index);
11952
11953 if (kvm_write_guest(vcpu->kvm, dst, &gpa, sizeof(gpa)))
11954 return 0;
11955
11956 vmcs12->guest_pml_index--;
11957 }
11958
11959 return 0;
11960 }
11961
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63101 bytes --]
next prev parent reply other threads:[~2018-02-23 2:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 17:47 [PATCH 00/10] KVM/X86: Handle guest memory that does not have a struct page KarimAllah Ahmed
2018-02-21 17:47 ` [PATCH 01/10] X86/nVMX: handle_vmon: Read 4 bytes from guest memory instead of map->read->unmap sequence KarimAllah Ahmed
2018-02-21 17:47 ` [PATCH 02/10] X86/nVMX: handle_vmptrld: Copy the VMCS12 directly from guest memory instead of map->copy->unmap sequence KarimAllah Ahmed
2018-02-21 17:47 ` [PATCH 03/10] X86/nVMX: Update the PML table without mapping and unmapping the page KarimAllah Ahmed
2018-02-23 2:02 ` kbuild test robot [this message]
2018-04-12 15:03 ` Paolo Bonzini
2018-02-21 17:47 ` [PATCH 04/10] KVM: Introduce a new guest mapping API KarimAllah Ahmed
2018-02-23 1:27 ` kbuild test robot
2018-02-23 1:37 ` kbuild test robot
2018-02-23 23:48 ` Raslan, KarimAllah
2018-04-12 14:33 ` Paolo Bonzini
2018-02-21 17:47 ` [PATCH 05/10] KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap KarimAllah Ahmed
2018-02-23 21:36 ` Konrad Rzeszutek Wilk
2018-02-23 23:45 ` Raslan, KarimAllah
2018-04-12 14:36 ` Paolo Bonzini
2018-02-21 17:47 ` [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page KarimAllah Ahmed
2018-04-12 14:38 ` Paolo Bonzini
2018-04-12 17:57 ` Sean Christopherson
2018-04-12 20:23 ` Paolo Bonzini
2018-02-21 17:47 ` [PATCH 07/10] KVM/nVMX: Use kvm_vcpu_map when mapping the posted interrupt descriptor table KarimAllah Ahmed
2018-04-12 14:39 ` Paolo Bonzini
2018-02-21 17:47 ` [PATCH 08/10] KVM/X86: Use kvm_vcpu_map in emulator_cmpxchg_emulated KarimAllah Ahmed
2018-02-22 2:56 ` Raslan, KarimAllah
2018-02-21 17:47 ` [PATCH 09/10] KVM/X86: hyperv: Use kvm_vcpu_map in synic_clear_sint_msg_pending KarimAllah Ahmed
2018-02-21 17:47 ` [PATCH 10/10] KVM/X86: hyperv: Use kvm_vcpu_map in synic_deliver_msg KarimAllah Ahmed
2018-03-01 15:24 ` [PATCH 00/10] KVM/X86: Handle guest memory that does not have a struct page Raslan, KarimAllah
2018-03-01 17:51 ` Jim Mattson
2018-03-02 17:40 ` Paolo Bonzini
2018-04-12 14:59 ` Paolo Bonzini
2018-04-12 21:25 ` Raslan, KarimAllah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201802230930.RXBHE4wM%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=karahmed@amazon.de \
--cc=kbuild-all@01.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).