Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

[Sebastian Reichel <sebastian.reichel@collabora.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

Hi,

On Fri, Feb 23, 2018 at 09:07:14AM +0100, Pavel Machek wrote:
> On Fri 2018-02-16 14:27:16, Mark Brown wrote:
> > On Fri, Feb 16, 2018 at 02:51:13PM +0100, Sebastian Reichel wrote:
> > > On Fri, Feb 16, 2018 at 11:39:01AM +0000, Mark Brown wrote:
> > 
> > > > We don't have default lines like this for other MFDs...
> > 
> > > Is there a reason not to add them? It looks very useful to me:
> > 
> > Consistency.  It's a lot easier to apply a single rule to everything
> > than it is to have to individually think through and discuss the
> > decisions on every individual driver, especially when there will
> > inevitably be some cases where there are conflicting requirements from
> > different users.  As you said in the rest of your mail hand configuring
> > kernels is already a very specialist thing at the best of times.
> 
> Yes, so please don't make it any harder than it needs to be. Having to
> enable (by hand) more than one option per chip is annoying and error-prone.

I will drop this and instead provide a new patch, which converts all
codecs depending on MFD_XYZ to have "default MFD_XYZ". This means,
that there will be consistency and we can discuss this with a bigger
audience without blocking the actual driver patches.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]