From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3704313-1519413978-2-3776226706234847098 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1519413977; b=t8JfV+c0Wf/MJLWxb2ZtbS+tYqSZ1wZc/aC5OHvPzRJNlQn ykFp4UmBFc2dRLZjjYiJPJFpx2+IqPnCeY9oglUYIzzcpybSc4tIe+T4mEMatfSt ALjJuhbOpik2DyCotdkaIQnH2cIcPOU8VuTfILrQ46uptP0whJSF5g1kyrKhejkq qePJsML0Ckei/qjY7pRhCyv3lqVIcz0Lk7T3JIB8LYRSOqtK/g9WWdGPgZIraAWq sb61VHmOJ+ja0jgfBOYV0GRZxHgTVHHZUjn16RHtN6LgoKLvoN7fvVeI9ONB4nuQ uOOqXZHLbwY2h01LycLPgvHWA5QLO2h0kF6XysQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=arctest; t=1519413977; bh=WyUbSsHFKUMikdgDhZ2mRxUREn 3GnvwIUq/JfL/sD9s=; b=gf58zMmYTTg4/cWdJzDQxGheDSvqe/mqNbFs4DfhAO /oWQZlFq1PhEc0lsvvDROIMI3vUgMyubx+F+HeGIRKK9JZXQt0IxeLs1qD3NPfUD MMzihemcALVoGoT0qF9TTFEod+5WZnhCJFgN+5k11skvnwb3oMPduQZF8z6IBkSV bqMT1xkORLUhlbwXSzy8dvze0b1QHYuSx6d17QvlCY2JzVESj5RhxJElk9WTa+aD phdXzjrhbNem9wP6wWilK9SwYLX4KmY4pkxXYXZVYxZJ2WAVjI3WqeGLwxQTSy+0 MrWx4rV/Faz1q7XtwpTKhtPEgXTQDij0/a3Bz2FWfoYA== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935184AbeBWSwl (ORCPT ); Fri, 23 Feb 2018 13:52:41 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47042 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935166AbeBWSwk (ORCPT ); Fri, 23 Feb 2018 13:52:40 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+4fbcfcc0d2e6592bd641@syzkaller.appspotmail.com, Pablo Neira Ayuso , Cong Wang Subject: [PATCH 4.14 039/159] netfilter: xt_cgroup: initialize info->priv in cgroup_mt_check_v1() Date: Fri, 23 Feb 2018 19:25:47 +0100 Message-Id: <20180223170748.150467578@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170743.086611315@linuxfoundation.org> References: <20180223170743.086611315@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cong Wang commit ba7cd5d95f25cc6005f687dabdb4e7a6063adda9 upstream. xt_cgroup_info_v1->priv is an internal pointer only used for kernel, we should not trust what user-space provides. Reported-by: Fixes: c38c4597e4bf ("netfilter: implement xt_cgroup cgroup2 path match") Cc: Pablo Neira Ayuso Signed-off-by: Cong Wang Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/netfilter/xt_cgroup.c | 1 + 1 file changed, 1 insertion(+) --- a/net/netfilter/xt_cgroup.c +++ b/net/netfilter/xt_cgroup.c @@ -52,6 +52,7 @@ static int cgroup_mt_check_v1(const stru return -EINVAL; } + info->priv = NULL; if (info->has_path) { cgrp = cgroup_get_from_path(info->path); if (IS_ERR(cgrp)) {