From: Yazen Ghannam <Yazen.Ghannam@amd.com>
To: linux-efi@vger.kernel.org
Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>,
linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org,
bp@suse.de, x86@kernel.org
Subject: [PATCH 3/8] efi: Decode IA32/X64 Processor Error Info Structure
Date: Fri, 23 Feb 2018 14:03:28 -0600 [thread overview]
Message-ID: <20180223200333.6410-4-Yazen.Ghannam@amd.com> (raw)
In-Reply-To: <20180223200333.6410-1-Yazen.Ghannam@amd.com>
From: Yazen Ghannam <yazen.ghannam@amd.com>
Print the fields in the IA32/X64 Processor Error Info Structure.
Based on UEFI 2.7 Table 256. IA32/X64 Processor Error Information
Structure.
Cc: <stable@vger.kernel.org> # 4.16.x
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
---
drivers/firmware/efi/cper-x86.c | 53 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c
index b50ee3cdf637..9d608f742c98 100644
--- a/drivers/firmware/efi/cper-x86.c
+++ b/drivers/firmware/efi/cper-x86.c
@@ -4,15 +4,28 @@
#include <linux/cper.h>
+#define INDENT_SP " "
+
/*
* We don't need a "CPER_IA" prefix since these are all locally defined.
* This will save us a lot of line space.
*/
#define VALID_LAPIC_ID BIT_ULL(0)
#define VALID_CPUID_INFO BIT_ULL(1)
+#define VALID_PROC_ERR_INFO_NUM(bits) ((bits & GENMASK_ULL(7, 2)) >> 2)
+
+#define INFO_VALID_CHECK_INFO BIT_ULL(0)
+#define INFO_VALID_TARGET_ID BIT_ULL(1)
+#define INFO_VALID_REQUESTOR_ID BIT_ULL(2)
+#define INFO_VALID_RESPONDER_ID BIT_ULL(3)
+#define INFO_VALID_IP BIT_ULL(4)
void cper_print_proc_ia(const char *pfx, const struct cper_sec_proc_ia *proc)
{
+ int i;
+ struct cper_ia_err_info *err_info;
+ char newpfx[64];
+
printk("%sValidation Bits: 0x%016llx\n", pfx, proc->validation_bits);
if (proc->validation_bits & VALID_LAPIC_ID)
@@ -23,4 +36,44 @@ void cper_print_proc_ia(const char *pfx, const struct cper_sec_proc_ia *proc)
print_hex_dump(pfx, "", DUMP_PREFIX_OFFSET, 16, 4, proc->cpuid,
sizeof(proc->cpuid), 0);
}
+
+ snprintf(newpfx, sizeof(newpfx), "%s%s", pfx, INDENT_SP);
+
+ err_info = (struct cper_ia_err_info *)(proc + 1);
+ for (i = 0; i < VALID_PROC_ERR_INFO_NUM(proc->validation_bits); i++) {
+ printk("%sError Information Structure %d:\n", pfx, i);
+
+ printk("%sError Structure Type: %pUl\n", newpfx,
+ &err_info->err_type);
+
+ printk("%sValidation Bits: 0x%016llx\n",
+ newpfx, err_info->validation_bits);
+
+ if (err_info->validation_bits & INFO_VALID_CHECK_INFO) {
+ printk("%sCheck Information: 0x%016llx\n", newpfx,
+ err_info->check_info);
+ }
+
+ if (err_info->validation_bits & INFO_VALID_TARGET_ID) {
+ printk("%sTarget Identifier: 0x%016llx\n",
+ newpfx, err_info->target_id);
+ }
+
+ if (err_info->validation_bits & INFO_VALID_REQUESTOR_ID) {
+ printk("%sRequestor Identifier: 0x%016llx\n",
+ newpfx, err_info->requestor_id);
+ }
+
+ if (err_info->validation_bits & INFO_VALID_RESPONDER_ID) {
+ printk("%sResponder Identifier: 0x%016llx\n",
+ newpfx, err_info->responder_id);
+ }
+
+ if (err_info->validation_bits & INFO_VALID_IP) {
+ printk("%sInstruction Pointer: 0x%016llx\n",
+ newpfx, err_info->ip);
+ }
+
+ err_info++;
+ }
}
--
2.14.1
next prev parent reply other threads:[~2018-02-23 20:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 20:03 [PATCH 0/8] Decode IA32/X64 CPER Yazen Ghannam
2018-02-23 20:03 ` [PATCH 1/8] efi: Fix IA32/X64 Processor Error Record definition Yazen Ghannam
2018-02-23 20:03 ` [PATCH 2/8] efi: Decode IA32/X64 Processor Error Section Yazen Ghannam
2018-02-24 16:38 ` Ard Biesheuvel
2018-02-26 15:55 ` Ghannam, Yazen
2018-02-23 20:03 ` Yazen Ghannam [this message]
2018-02-24 16:40 ` [PATCH 3/8] efi: Decode IA32/X64 Processor Error Info Structure Ard Biesheuvel
2018-02-26 16:00 ` Ghannam, Yazen
2018-02-26 16:04 ` Ard Biesheuvel
2018-02-23 20:03 ` [PATCH 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure GUIDs Yazen Ghannam
2018-02-24 16:41 ` Ard Biesheuvel
2018-02-26 16:01 ` Ghannam, Yazen
2018-02-23 20:03 ` [PATCH 5/8] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures Yazen Ghannam
2018-02-24 16:42 ` Ard Biesheuvel
2018-02-23 20:03 ` [PATCH 6/8] efi: Decode additional IA32/X64 Bus Check fields Yazen Ghannam
2018-02-24 16:43 ` Ard Biesheuvel
2018-02-23 20:03 ` [PATCH 7/8] efi: Decode IA32/X64 MS Check structure Yazen Ghannam
2018-02-24 16:43 ` Ard Biesheuvel
2018-02-23 20:03 ` [PATCH 8/8] efi: Decode IA32/X64 Context Info structure Yazen Ghannam
2018-02-24 16:45 ` Ard Biesheuvel
2018-02-26 16:05 ` Ghannam, Yazen
2018-02-26 16:06 ` Ard Biesheuvel
2018-02-24 16:46 ` [PATCH 0/8] Decode IA32/X64 CPER Ard Biesheuvel
2018-02-26 15:46 ` Ghannam, Yazen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223200333.6410-4-Yazen.Ghannam@amd.com \
--to=yazen.ghannam@amd.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@suse.de \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).