* [PATCH] i2c: xiic: Fix PM device usage count
@ 2018-02-24 22:44 Tobias Jordan
0 siblings, 0 replies; only message in thread
From: Tobias Jordan @ 2018-02-24 22:44 UTC (permalink / raw)
To: linux-i2c, linux-kernel; +Cc: Wolfram Sang
pm_runtime_get_sync() increases the device's usage count even when
reporting an error, so add a call to pm_runtime_put_noidle() in the
error branch.
Fixes: 36ecbcab84d0 ("i2c: xiic: Implement power management")
Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
---
This is one of a number of patches for problems found using coccinelle
scripting in the SIL2LinuxMP project. The patch has been compile-tested;
it's based on linux-next-20180223.
For a discussion of the corresponding issue, see
https://marc.info/?l=linux-pm&m=151904483924999&w=2
drivers/i2c/busses/i2c-xiic.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index ae6ed254e01d..fd03e40ca832 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -682,8 +682,10 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
xiic_getreg8(i2c, XIIC_SR_REG_OFFSET));
err = pm_runtime_get_sync(i2c->dev);
- if (err < 0)
+ if (err < 0) {
+ pm_runtime_put_noidle(i2c->dev);
return err;
+ }
err = xiic_busy(i2c);
if (err)
--
2.11.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-02-24 22:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-24 22:44 [PATCH] i2c: xiic: Fix PM device usage count Tobias Jordan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).