From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: wim@linux-watchdog.org, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
rwright@hpe.com, maurice.a.saldivar@hpe.com, mingo@kernel.org,
marcus.folkesson@gmail.com, Jerry Hoemann <jerry.hoemann@hpe.com>
Subject: [PATCH v5 3/9] watchdog/hpwdt: Update nmi_panic message.
Date: Sun, 25 Feb 2018 20:22:21 -0700 [thread overview]
Message-ID: <20180226032227.14615-4-jerry.hoemann@hpe.com> (raw)
In-Reply-To: <20180226032227.14615-1-jerry.hoemann@hpe.com>
Include the nmistat in the nmi_panic message to give support
an indication why the NMI was called (e.g. a timeout or generate
nmi button.)
Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
---
drivers/watchdog/hpwdt.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 1d20bc6d2c44..44c3038cc531 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -113,19 +113,23 @@ static int hpwdt_my_nmi(void)
*/
static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
{
- if ((ulReason == NMI_UNKNOWN) && !hpwdt_my_nmi())
+ unsigned int mynmi = hpwdt_my_nmi();
+ static char panic_msg[] =
+ "00: An NMI occurred. Depending on your system the reason "
+ "for the NMI is logged in any one of the following resources:\n"
+ "1. Integrated Management Log (IML)\n"
+ "2. OA Syslog\n"
+ "3. OA Forward Progress Log\n"
+ "4. iLO Event Log";
+
+ if ((ulReason == NMI_UNKNOWN) && mynmi)
return NMI_DONE;
if (allow_kdump)
hpwdt_stop();
- nmi_panic(regs, "An NMI occurred. Depending on your system the reason "
- "for the NMI is logged in any one of the following "
- "resources:\n"
- "1. Integrated Management Log (IML)\n"
- "2. OA Syslog\n"
- "3. OA Forward Progress Log\n"
- "4. iLO Event Log");
+ hex_byte_pack(panic_msg, mynmi);
+ nmi_panic(regs, panic_msg);
return NMI_HANDLED;
}
--
2.13.6
next prev parent reply other threads:[~2018-02-26 3:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 3:22 [PATCH v5 0/9] watchdog/hpwdt: Update driver to use watchdog core Jerry Hoemann
2018-02-26 3:22 ` [PATCH v5 1/9] watchdog/hpwdt: Update Module info and copyright Jerry Hoemann
2018-02-26 3:22 ` [PATCH v5 2/9] watchdog/hpwdt: Remove legacy NMI sourcing Jerry Hoemann
2018-02-26 14:11 ` Arnd Bergmann
2018-02-26 14:32 ` Guenter Roeck
2018-02-27 1:02 ` Jerry Hoemann
2018-02-27 1:29 ` Guenter Roeck
2018-02-28 19:45 ` Jerry Hoemann
2018-03-02 4:42 ` Guenter Roeck
2018-02-26 3:22 ` Jerry Hoemann [this message]
2018-02-26 3:22 ` [PATCH v5 4/9] watchdog/hpwdt: Modify to use watchdog core Jerry Hoemann
2018-02-26 3:22 ` [PATCH v5 5/9] watchdog/hpwdt: condition early return of NMI handler on iLO5 Jerry Hoemann
2018-02-26 3:22 ` [PATCH v5 6/9] watchdog/hpwdt: remove allow_kdump module parameter Jerry Hoemann
2018-02-26 3:22 ` [PATCH v5 7/9] watchdog/hpwdt: Programable Pretimeout NMI Jerry Hoemann
2018-02-26 3:22 ` [PATCH v5 8/9] watchdog/hpwdt: Add dynamic debug Jerry Hoemann
2018-02-26 3:22 ` [PATCH v5 9/9] watchdog/hpwdt: Update driver version Jerry Hoemann
2018-03-02 4:42 ` [PATCH v5 0/9] watchdog/hpwdt: Update driver to use watchdog core Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226032227.14615-4-jerry.hoemann@hpe.com \
--to=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcus.folkesson@gmail.com \
--cc=maurice.a.saldivar@hpe.com \
--cc=mingo@kernel.org \
--cc=rwright@hpe.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).