From: Ram Pai <linuxram@us.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, mpe@ellerman.id.au, mingo@redhat.com,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, dave.hansen@intel.com,
benh@kernel.crashing.org, paulus@samba.org,
khandual@linux.vnet.ibm.com, bsingharora@gmail.com,
hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com,
ebiederm@xmission.com, corbet@lwn.net, arnd@arndb.de,
fweimer@redhat.com, msuchanek@suse.com
Subject: Re: [PATCH v12 1/3] mm, powerpc, x86: define VM_PKEY_BITx bits if CONFIG_ARCH_HAS_PKEYS is enabled
Date: Sun, 25 Feb 2018 23:26:45 -0800 [thread overview]
Message-ID: <20180226072645.GA1060@ram.oc3035372033.ibm.com> (raw)
In-Reply-To: <43082fe4-a6e4-2468-0069-4fbc53418c79@linux.vnet.ibm.com>
On Sun, Feb 25, 2018 at 05:27:11PM +0530, Aneesh Kumar K.V wrote:
>
>
> On 02/24/2018 06:35 AM, Ram Pai wrote:
> >On Fri, Feb 23, 2018 at 03:11:45PM +0800, kbuild test robot wrote:
> >>Hi Ram,
> >>
> >>Thank you for the patch! Yet something to improve:
> >>
> >>[auto build test ERROR on linus/master]
> >>[also build test ERROR on v4.16-rc2 next-20180222]
> >>[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >>
> >> chmod +x ~/bin/make.cross
> >...snip..
> >> # save the attached .config to linux build tree
> >> make.cross ARCH=powerpc
> >>
> >>Note: the linux-review/Ram-Pai/mm-x86-powerpc-Enhancements-to-Memory-Protection-Keys/20180223-042743 HEAD c5692bca45543c242ffca15c811923e4c548ed19 builds fine.
> >> It only hurts bisectibility.
> >
> >oops, it broke git-bisect on powerpc :-(
> >The following change will fix it. This should nail it down.
> >
> >diff --git a/arch/powerpc/include/asm/pkeys.h
> >b/arch/powerpc/include/asm/pkeys.h
> >index 0409c80..0b3b669 100644
> >--- a/arch/powerpc/include/asm/pkeys.h
> >+++ b/arch/powerpc/include/asm/pkeys.h
> >@@ -25,6 +25,7 @@
> > # define VM_PKEY_BIT1 VM_HIGH_ARCH_1
> > # define VM_PKEY_BIT2 VM_HIGH_ARCH_2
> > # define VM_PKEY_BIT3 VM_HIGH_ARCH_3
> > # define VM_PKEY_BIT4 VM_HIGH_ARCH_4
> >+#elif !defined(VM_PKEY_BIT4)
> >+# define VM_PKEY_BIT4 VM_HIGH_ARCH_4
> >#endif
> >
>
> Why don't you remove this powerpc definition completely in this
> patch?
That was my thought too, but refrained from sneaking in the changes into
the patch, to maintain the integrity of all the reviewed-by.
Was planning on sending a seperate patch to remove the
powerpc definition entirely.
RP
next prev parent reply other threads:[~2018-02-26 7:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 23:52 [PATCH v12 0/3] mm, x86, powerpc: Enhancements to Memory Protection Keys Ram Pai
2018-02-21 23:52 ` [PATCH v12 1/3] mm, powerpc, x86: define VM_PKEY_BITx bits if CONFIG_ARCH_HAS_PKEYS is enabled Ram Pai
2018-02-23 7:11 ` kbuild test robot
2018-02-24 1:05 ` Ram Pai
2018-02-25 11:57 ` Aneesh Kumar K.V
2018-02-26 7:26 ` Ram Pai [this message]
2018-02-23 8:06 ` kbuild test robot
2018-02-26 21:12 ` Dave Hansen
2018-02-21 23:52 ` [PATCH v12 2/3] mm, powerpc, x86: introduce an additional vma bit for powerpc pkey Ram Pai
2018-02-26 21:14 ` Dave Hansen
2018-02-21 23:52 ` [PATCH v12 3/3] mm, x86, powerpc: display pkey in smaps only if arch supports pkeys Ram Pai
2018-02-26 21:16 ` Dave Hansen
2018-03-08 18:25 ` mm, x86, powerpc: pkey semantics for key-0 ? Ram Pai
2018-03-08 19:30 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226072645.GA1060@ram.oc3035372033.ibm.com \
--to=linuxram@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=bauerman@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=ebiederm@xmission.com \
--cc=fweimer@redhat.com \
--cc=hbabu@us.ibm.com \
--cc=kbuild-all@01.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.com \
--cc=paulus@samba.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).