Hi, On Sun, Feb 25, 2018 at 09:50:45PM +0800, hao_zhang wrote: > This patch adds allwinner sun8i pwm binding documents. > > Signed-off-by: hao_zhang > --- > Documentation/devicetree/bindings/pwm/pwm-sun8i.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sun8i.txt > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt b/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt > new file mode 100644 > index 0000000..e8c48be > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-sun8i.txt > @@ -0,0 +1,18 @@ > +Allwinner sun8i R40/V40/T3 SoC PWM controller > + > +Required properties: > + - compatible: should be one of: > + - "allwinner,sun8i-r40-pwm" > + - reg: physical base address and length of the controller's registers > + - #pwm-cells: should be 3. See pwm.txt in this directory for a description of > + the cells format. > + - clocks: From common clock binding, handle to the parent clock. > + > +Example: > + > +pwm: pwm@1c23400 { > + compatible = "allwinner,sun8i-pwm"; The compatible you have here isn't the one documented. > + reg = <0x01c23400 0x154>; And the size isn't correct, even though that doesn't really make any difference here. Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com