From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 09/12] usb: roles: Add Intel xHCI USB role switch driver
Date: Mon, 26 Feb 2018 13:42:11 +0200 [thread overview]
Message-ID: <20180226114211.GA25535@kuha.fi.intel.com> (raw)
In-Reply-To: <20180226090925.29436-10-hdegoede@redhat.com>
On Mon, Feb 26, 2018 at 10:09:22AM +0100, Hans de Goede wrote:
> Various Intel SoCs (Cherry Trail, Broxton and others) have an internal USB
> role switch for swiching the OTG USB data lines between the xHCI host
> controller and the dwc3 gadget controller.
>
> Note on some Cherry Trail systems there is ACPI/AML code listening to
> edge interrupts on the id-pin (through an _AIE ACPI method) and switching
> the role between ROLE_HOST and ROLE_NONE based on the id-pin. Note it does
> not set the role to ROLE_DEVICE, because device-mode is usually not used
> under Windows.
>
> The presence of AML code which modifies the cfg0 reg (on some systems)
> means that our read/write/modify of cfg0 may race with the AML code
> doing the same to avoid this we take the global ACPI lock while doing
> the read/write/modify.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Thanks Hans!
--
heikki
next prev parent reply other threads:[~2018-02-26 11:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 9:09 [PATCH v3 00/12] USB Type-C device-connection, mux and switch support Hans de Goede
2018-02-26 9:09 ` [PATCH v3 01/12] drivers: base: Unified device connection lookup Hans de Goede
2018-02-26 9:09 ` [PATCH v3 02/12] usb: typec: Start using ERR_PTR Hans de Goede
2018-02-26 9:09 ` [PATCH v3 03/12] usb: typec: API for controlling USB Type-C Multiplexers Hans de Goede
2018-02-26 9:09 ` [PATCH v3 04/12] usb: common: Small class for USB role switches Hans de Goede
2018-02-26 9:09 ` [PATCH v3 05/12] usb: typec: tcpm: Set USB role switch to device mode when configured as such Hans de Goede
2018-02-26 9:09 ` [PATCH v3 06/12] usb: typec: tcpm: Use new Type-C switch/mux and usb-role-switch functions Hans de Goede
2018-02-26 9:09 ` [PATCH v3 07/12] xhci: Add option to get next extended capability in list by passing id = 0 Hans de Goede
2018-02-26 9:09 ` [PATCH v3 08/12] xhci: Add Intel extended cap / otg phy mux handling Hans de Goede
2018-02-26 9:09 ` [PATCH v3 09/12] usb: roles: Add Intel xHCI USB role switch driver Hans de Goede
2018-02-26 11:42 ` Heikki Krogerus [this message]
2018-02-26 9:09 ` [PATCH v3 10/12] usb: typec: driver for Pericom PI3USB30532 Type-C cross switch Hans de Goede
2018-02-26 9:09 ` [PATCH v3 11/12] platform/x86: intel_cht_int33fe: Add device connections for the Type-C port Hans de Goede
2018-02-26 9:09 ` [PATCH v3 12/12] extcon: axp288: Set USB role where necessary Hans de Goede
2018-02-26 10:59 ` [PATCH v3 00/12] USB Type-C device-connection, mux and switch support Andy Shevchenko
2018-02-26 11:19 ` Hans de Goede
2018-02-26 11:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226114211.GA25535@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andy@infradead.org \
--cc=cw00.choi@samsung.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathias.nyman@intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).