From: Stephen Hemminger <stephen@networkplumber.org>
To: Michael Kelley <mhkelley@outlook.com>
Cc: "olaf@aepfle.de" <olaf@aepfle.de>,
"sthemmin@microsoft.com" <sthemmin@microsoft.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mikelley@microsoft.com" <mikelley@microsoft.com>,
"marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>,
"apw@canonical.com" <apw@canonical.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"leann.ogasawara@canonical.com" <leann.ogasawara@canonical.com>
Subject: Re: [PATCH v2 char-misc 1/1] Drivers: hv: vmbus: Fix ring buffer signaling
Date: Mon, 26 Feb 2018 16:10:00 -0800 [thread overview]
Message-ID: <20180226161000.2b7a7214@xeon-e3> (raw)
In-Reply-To: <SN6PR1901MB20450EF7C8CC4112381274B9CBCB0@SN6PR1901MB2045.namprd19.prod.outlook.com>
On Fri, 16 Feb 2018 23:05:33 +0000
Michael Kelley <mhkelley@outlook.com> wrote:
> Fix bugs in signaling the Hyper-V host when freeing space in the
> host->guest ring buffer:
>
> 1. The interrupt_mask must not be used to determine whether to signal
> on the host->guest ring buffer
> 2. The ring buffer write_index must be read (via hv_get_bytes_to_write)
> *after* pending_send_sz is read in order to avoid a race condition
> 3. Comparisons with pending_send_sz must treat the "equals" case as
> not-enough-space
> 4. Don't signal if the pending_send_sz feature is not present. Older
> versions of Hyper-V that don't implement this feature will poll.
>
> Fixes: 03bad714a161 ("vmbus: more host signalling avoidance")
> Signed-off-by: Michael Kelley <mhkelley@outlook.com>
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-02-27 0:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 23:05 [PATCH v2 char-misc 1/1] Drivers: hv: vmbus: Fix ring buffer signaling Michael Kelley
2018-02-27 0:10 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226161000.2b7a7214@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mhkelley@outlook.com \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).