* [PATCH] perf top: Fix annoying fallback message on older kernel
@ 2018-02-26 18:17 kan.liang
2018-02-26 19:20 ` Arnaldo Carvalho de Melo
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: kan.liang @ 2018-02-26 18:17 UTC (permalink / raw)
To: mingo, acme; +Cc: linux-kernel, Kan Liang
From: Kan Liang <Kan.liang@intel.com>
On older (v4.4) kernels, the annoying fallback message can be observed
in 'perf top'.
The 'perf top' has been changed to overwrite mode since
'commit ebebbf082357 ("perf top: Switch default mode to overwrite mode")'
For the older kernels which don't have overwrite mode support, the 'perf
top' will fall back to non-overwrite mode and print out the fallback
message by ui__warning, which needs user's input to close.
The fallback message is not critical message for end users. Turning it
to debug message which is printed when running with -vv.
Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Kan Liang <Kan.liang@intel.com>
---
tools/perf/builtin-top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index b7c823b..35ac016 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
evlist__for_each_entry(evlist, counter)
counter->attr.write_backward = false;
opts->overwrite = false;
- ui__warning("fall back to non-overwrite mode\n");
+ pr_debug2("fall back to non-overwrite mode\n");
return 1;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] perf top: Fix annoying fallback message on older kernel
2018-02-26 18:17 [PATCH] perf top: Fix annoying fallback message on older kernel kan.liang
@ 2018-02-26 19:20 ` Arnaldo Carvalho de Melo
2018-02-27 6:53 ` Ingo Molnar
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-02-26 19:20 UTC (permalink / raw)
To: kan.liang; +Cc: mingo, linux-kernel
Em Mon, Feb 26, 2018 at 10:17:10AM -0800, kan.liang@intel.com escreveu:
> The fallback message is not critical message for end users. Turning it
> to debug message which is printed when running with -vv.
> Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
> Reported-by: Ingo Molnar <mingo@kernel.org>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf top: Fix annoying fallback message on older kernel
2018-02-26 18:17 [PATCH] perf top: Fix annoying fallback message on older kernel kan.liang
2018-02-26 19:20 ` Arnaldo Carvalho de Melo
@ 2018-02-27 6:53 ` Ingo Molnar
2018-03-06 6:42 ` [tip:perf/core] perf top: Fix annoying fallback message on older kernels tip-bot for Kan Liang
2018-03-07 8:25 ` [tip:perf/urgent] " tip-bot for Kan Liang
3 siblings, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2018-02-27 6:53 UTC (permalink / raw)
To: kan.liang; +Cc: acme, linux-kernel
* kan.liang@intel.com <kan.liang@intel.com> wrote:
> From: Kan Liang <Kan.liang@intel.com>
>
> On older (v4.4) kernels, the annoying fallback message can be observed
> in 'perf top'.
>
> The 'perf top' has been changed to overwrite mode since
> 'commit ebebbf082357 ("perf top: Switch default mode to overwrite mode")'
> For the older kernels which don't have overwrite mode support, the 'perf
> top' will fall back to non-overwrite mode and print out the fallback
> message by ui__warning, which needs user's input to close.
>
> The fallback message is not critical message for end users. Turning it
> to debug message which is printed when running with -vv.
>
> Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
> Reported-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Kan Liang <Kan.liang@intel.com>
> ---
> tools/perf/builtin-top.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index b7c823b..35ac016 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
> evlist__for_each_entry(evlist, counter)
> counter->attr.write_backward = false;
> opts->overwrite = false;
> - ui__warning("fall back to non-overwrite mode\n");
> + pr_debug2("fall back to non-overwrite mode\n");
> return 1;
> }
Thanks!
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/core] perf top: Fix annoying fallback message on older kernels
2018-02-26 18:17 [PATCH] perf top: Fix annoying fallback message on older kernel kan.liang
2018-02-26 19:20 ` Arnaldo Carvalho de Melo
2018-02-27 6:53 ` Ingo Molnar
@ 2018-03-06 6:42 ` tip-bot for Kan Liang
2018-03-07 8:25 ` [tip:perf/urgent] " tip-bot for Kan Liang
3 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Kan Liang @ 2018-03-06 6:42 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, Kan.liang, mingo, tglx, linux-kernel, kan.liang, hpa
Commit-ID: 853745f5e6d95faaae6381c9a01dbd43de992fb3
Gitweb: https://git.kernel.org/tip/853745f5e6d95faaae6381c9a01dbd43de992fb3
Author: Kan Liang <Kan.liang@intel.com>
AuthorDate: Mon, 26 Feb 2018 10:17:10 -0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 26 Feb 2018 16:04:08 -0300
perf top: Fix annoying fallback message on older kernels
On older (e.g. v4.4) kernels, an annoying fallback message can be
observed in 'perf top':
┌─Warning:──────────────────────┐
│fall back to non-overwrite mode│
│ │
│ │
│Press any key... │
└───────────────────────────────┘
The 'perf top' utility has been changed to overwrite mode since commit
ebebbf082357 ("perf top: Switch default mode to overwrite mode").
For older kernels which don't have overwrite mode support, 'perf top'
will fall back to non-overwrite mode and print out the fallback message
using ui__warning(), which needs user's input to close.
The fallback message is not critical for end users. Turning it to debug
message which is printed when running with -vv.
Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Kan Liang <kan.liang@intel.com>
Cc: Kan Liang <kan.liang@intel.com>
Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
Link: http://lkml.kernel.org/r/1519669030-176549-1-git-send-email-kan.liang@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index b7c823ba8374..35ac016fcb98 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
evlist__for_each_entry(evlist, counter)
counter->attr.write_backward = false;
opts->overwrite = false;
- ui__warning("fall back to non-overwrite mode\n");
+ pr_debug2("fall back to non-overwrite mode\n");
return 1;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [tip:perf/urgent] perf top: Fix annoying fallback message on older kernels
2018-02-26 18:17 [PATCH] perf top: Fix annoying fallback message on older kernel kan.liang
` (2 preceding siblings ...)
2018-03-06 6:42 ` [tip:perf/core] perf top: Fix annoying fallback message on older kernels tip-bot for Kan Liang
@ 2018-03-07 8:25 ` tip-bot for Kan Liang
3 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Kan Liang @ 2018-03-07 8:25 UTC (permalink / raw)
To: linux-tip-commits
Cc: kan.liang, Kan.liang, tglx, mingo, linux-kernel, acme, hpa
Commit-ID: 626af862da9c650e80bdea44684be9334f8eb75b
Gitweb: https://git.kernel.org/tip/626af862da9c650e80bdea44684be9334f8eb75b
Author: Kan Liang <Kan.liang@intel.com>
AuthorDate: Mon, 26 Feb 2018 10:17:10 -0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 5 Mar 2018 11:48:56 -0300
perf top: Fix annoying fallback message on older kernels
On older (e.g. v4.4) kernels, an annoying fallback message can be
observed in 'perf top':
┌─Warning:──────────────────────┐
│fall back to non-overwrite mode│
│ │
│ │
│Press any key... │
└───────────────────────────────┘
The 'perf top' utility has been changed to overwrite mode since commit
ebebbf082357 ("perf top: Switch default mode to overwrite mode").
For older kernels which don't have overwrite mode support, 'perf top'
will fall back to non-overwrite mode and print out the fallback message
using ui__warning(), which needs user's input to close.
The fallback message is not critical for end users. Turning it to debug
message which is printed when running with -vv.
Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Kan Liang <kan.liang@intel.com>
Cc: Kan Liang <kan.liang@intel.com>
Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
Link: http://lkml.kernel.org/r/1519669030-176549-1-git-send-email-kan.liang@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index b7c823ba8374..35ac016fcb98 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
evlist__for_each_entry(evlist, counter)
counter->attr.write_backward = false;
opts->overwrite = false;
- ui__warning("fall back to non-overwrite mode\n");
+ pr_debug2("fall back to non-overwrite mode\n");
return 1;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-07 8:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 18:17 [PATCH] perf top: Fix annoying fallback message on older kernel kan.liang
2018-02-26 19:20 ` Arnaldo Carvalho de Melo
2018-02-27 6:53 ` Ingo Molnar
2018-03-06 6:42 ` [tip:perf/core] perf top: Fix annoying fallback message on older kernels tip-bot for Kan Liang
2018-03-07 8:25 ` [tip:perf/urgent] " tip-bot for Kan Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).