On Tue, Feb 27, 2018 at 01:29:27PM +1100, Julian Calaby wrote: > Hi Jernej, > > On Tue, Feb 27, 2018 at 3:27 AM, Jernej Škrabec wrote: > > Hi, > > > > Dne ponedeljek, 26. februar 2018 ob 17:21:05 CET je Icenowy Zheng napisal(a): > >> 于 2018年2月27日 GMT+08:00 上午12:16:44, "Jernej Škrabec" > > 写到: > >> >Hi Julian, > >> > > >> >Dne nedelja, 25. februar 2018 ob 09:11:34 CET je Julian Calaby > >> > > >> >napisal(a): > >> >> Hi Jernej, > >> >> > >> >> On Sun, Feb 25, 2018 at 8:45 AM, Jernej Skrabec > >> > > >> > > >> > > >> >wrote: > >> >> > Enable HDMI output on all boards which have HDMI connector. > >> >> > > >> >> > Signed-off-by: Jernej Skrabec > >> >> > --- > >> >> > > >> >> > arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 25 > >> >> > ++++++++++++++++++++++ arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > >> >> > > >> >> > | 25 ++++++++++++++++++++++ > >> >> > > >> >> > arch/arm/boot/dts/sun8i-h3-libretech-all-h3-cc.dts | 25 > >> >> > ++++++++++++++++++++++ arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts > >> >> > > >> >> > | 25 ++++++++++++++++++++++ > >> > > >> >arch/arm/boot/dts/sun8i-h3-orangepi-2.dts > >> > > >> >> > | 25 ++++++++++++++++++++++ > >> >> > > >> >> > arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 25 > >> >> > ++++++++++++++++++++++ arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > >> >> > > >> >> > | 24 +++++++++++++++++++++ > >> > > >> >arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts > >> > > >> >> > | 25 ++++++++++++++++++++++ 8 files changed, 199 > >> > > >> >insertions(+) > >> > > >> >> As I understand it, the H2+ is just a slightly trimmed down H3. In > >> >> terms of HDMI support, the difference is that the H2+ can't output > >> > > >> >4k. > >> > > >> >> If this code is compatible with the H2+, could you please add the > >> >> necessary bits and pieces to the h2-plus DTSs too? > >> > > >> >There are only 3 H2+ boards in kernel and none of them has HDMI > >> >connector, so > >> > >> BPi M2 Zero has miniHDMI connector. > > > > Ah, sorry, I missed that one. Since I don't have it (or any other board with > > H2+) I'm not really comfortable including such patch. If anyone will test it, > > I can include it in next revision. > > I have one of those (this is why I'm interested in this patchset) so > I'm willing to test, however I can't guarantee I'll get to it quickly. Then I guess the best way forward will be to keep the current patch as is, and you'll send a patch whenever you have the time to test it. Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com