* [PATCH] ssb: return boolean instead of integer in ssb_dma_translation_special_bit
@ 2018-01-18 23:54 Gustavo A. R. Silva
2018-02-27 16:14 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-01-18 23:54 UTC (permalink / raw)
To: Michael Buesch; +Cc: linux-wireless, linux-kernel, Gustavo A. R. Silva
Return statements in functions returning bool should use
true/false instead of 1/0.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/ssb/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 65420a9..fdb89b6 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1116,7 +1116,7 @@ static bool ssb_dma_translation_special_bit(struct ssb_device *dev)
chip_id == 43231 || chip_id == 43222);
}
- return 0;
+ return false;
}
u32 ssb_dma_translation(struct ssb_device *dev)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: ssb: return boolean instead of integer in ssb_dma_translation_special_bit
2018-01-18 23:54 [PATCH] ssb: return boolean instead of integer in ssb_dma_translation_special_bit Gustavo A. R. Silva
@ 2018-02-27 16:14 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-02-27 16:14 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Michael Buesch, linux-wireless, linux-kernel, Gustavo A. R. Silva
"Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote:
> Return statements in functions returning bool should use
> true/false instead of 1/0.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Patch applied to wireless-drivers-next.git, thanks.
bd42cd022e44 ssb: return boolean instead of integer in ssb_dma_translation_special_bit
--
https://patchwork.kernel.org/patch/10174387/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-27 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-18 23:54 [PATCH] ssb: return boolean instead of integer in ssb_dma_translation_special_bit Gustavo A. R. Silva
2018-02-27 16:14 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).