From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbeB0RFA (ORCPT ); Tue, 27 Feb 2018 12:05:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:47605 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbeB0REp (ORCPT ); Tue, 27 Feb 2018 12:04:45 -0500 Date: Tue, 27 Feb 2018 18:04:23 +0100 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ard.biesheuvel@linaro.org" , "x86@kernel.org" Subject: Re: [PATCH v2 3/8] efi: Decode IA32/X64 Processor Error Info Structure Message-ID: <20180227170423.GK26382@pd.tnic> References: <20180226193904.20532-1-Yazen.Ghannam@amd.com> <20180226193904.20532-4-Yazen.Ghannam@amd.com> <20180227142531.GF26382@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 27, 2018 at 03:25:06PM +0000, Ghannam, Yazen wrote: > This is the same as the other CPER code. Dude, turn on brain! So if it is in the other CPER code, we should copy it, no matter how dumb it is?!? > Also, the spec allows platform-defined GUIDs. So we should always print this > even if the GUID is not defined by the spec. We need to have a way to map the GUID to a hw part. Dumb numbers mean shit because the error record is worthless. > The Check Information will be decoded further in another patch. > > I don't think there's much else to decode for the ID fields. Again, those numbers can't help decoding the error, no need to dump them. Or we find a way to make sense out of that info. > Other tables may have the same fields but the offsets are usually different. > So it may be more trouble than it's worth trying to unify the different tables. If the structs are the same, you can use generic functions for dumping - the offsets are meaningless then. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --