From: David Miller <davem@davemloft.net>
To: maxime.chevallier@bootlin.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com,
gregory.clement@bootlin.com, miquel.raynal@bootlin.com,
nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com,
mw@semihalf.com
Subject: Re: [PATCH net-next v2] net: mvpp2: Add hardware offloading for VLAN filtering
Date: Wed, 28 Feb 2018 12:05:13 -0500 (EST) [thread overview]
Message-ID: <20180228.120513.2059500299754394497.davem@davemloft.net> (raw)
In-Reply-To: <20180228091413.10008-1-maxime.chevallier@bootlin.com>
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: Wed, 28 Feb 2018 10:14:13 +0100
> Marvell PPv2 controller allows for generic packet filtering. This commit
> adds entries to implement VLAN filtering. The approach taken is :
>
> - Filter entries that would match on the presence of the VLAN tag
> (existing VLAN detection, DSA / EDSA detection) will set the next
> lookup ID to be for the VID.
>
> - For each VLAN existing on a given port, we add an entry that matches
> this specific VID. If the incoming packet matches the VID entry, it is
> set for the next lookup in the chain (LU_L2).
>
> - A Guard entry is added for each port, that will match if the incoming
> packet didn't match any of the above VID entries. This entry tags the
> packet to be dropped.
>
> Due to this design, and the fact that the total 256 filter entries are
> also used for other purposes, we have a limit of 10 VLANs per port. To
> accommodate the case where we would need more VLANS on one port, this
> patch implements the ndo_set_features to allow for disabling of VLAN
> filtering using ethtool.
>
> The default config has VLAN filtering disabled.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> V2: Use correct order for local variable declarations
That looks better, applied, thank you.
prev parent reply other threads:[~2018-02-28 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 9:14 [PATCH net-next v2] net: mvpp2: Add hardware offloading for VLAN filtering Maxime Chevallier
2018-02-28 17:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228.120513.2059500299754394497.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=antoine.tenart@bootlin.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).