From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751692AbeB1FXK (ORCPT ); Wed, 28 Feb 2018 00:23:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:41052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbeB1FXJ (ORCPT ); Wed, 28 Feb 2018 00:23:09 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 657E52064E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jaegeuk@kernel.org Date: Tue, 27 Feb 2018 21:23:08 -0800 From: Jaegeuk Kim To: Chao Yu Cc: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: handle quota for orphan inodes Message-ID: <20180228052308.GE81737@jaegeuk-macbookpro.roam.corp.google.com> References: <20180210022841.5707-1-jaegeuk@kernel.org> <49c1d817-f375-4194-8139-c352503a9a2d@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49c1d817-f375-4194-8139-c352503a9a2d@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/27, Chao Yu wrote: > Ping, > > On 2018/2/13 22:33, Chao Yu wrote: > > On 2018/2/10 10:28, Jaegeuk Kim wrote: > >> This is to fix missing dquot_initialize for orphan inodes. > > > > IMO, we don't need to call dquot_initialize as we have call the function > > in evict(), right? I think we'd better detect any error in early stage. Thanks, > > > > Thanks, > > > >> > >> Signed-off-by: Jaegeuk Kim > >> --- > >> fs/f2fs/checkpoint.c | 28 ++++++++++++++++------------ > >> 1 file changed, 16 insertions(+), 12 deletions(-) > >> > >> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > >> index 8b0945ba284d..e3bf753a47be 100644 > >> --- a/fs/f2fs/checkpoint.c > >> +++ b/fs/f2fs/checkpoint.c > >> @@ -569,13 +569,8 @@ static int recover_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino) > >> struct node_info ni; > >> int err = acquire_orphan_inode(sbi); > >> > >> - if (err) { > >> - set_sbi_flag(sbi, SBI_NEED_FSCK); > >> - f2fs_msg(sbi->sb, KERN_WARNING, > >> - "%s: orphan failed (ino=%x), run fsck to fix.", > >> - __func__, ino); > >> - return err; > >> - } > >> + if (err) > >> + goto err_out; > >> > >> __add_ino_entry(sbi, ino, 0, ORPHAN_INO); > >> > >> @@ -589,6 +584,11 @@ static int recover_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino) > >> return PTR_ERR(inode); > >> } > >> > >> + err = dquot_initialize(inode); > >> + if (err) > >> + goto err_out; > >> + > >> + dquot_initialize(inode); > >> clear_nlink(inode); > >> > >> /* truncate all the data during iput */ > >> @@ -598,14 +598,18 @@ static int recover_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino) > >> > >> /* ENOMEM was fully retried in f2fs_evict_inode. */ > >> if (ni.blk_addr != NULL_ADDR) { > >> - set_sbi_flag(sbi, SBI_NEED_FSCK); > >> - f2fs_msg(sbi->sb, KERN_WARNING, > >> - "%s: orphan failed (ino=%x) by kernel, retry mount.", > >> - __func__, ino); > >> - return -EIO; > >> + err = -EIO; > >> + goto err_out; > >> } > >> __remove_ino_entry(sbi, ino, ORPHAN_INO); > >> return 0; > >> + > >> +err_out: > >> + set_sbi_flag(sbi, SBI_NEED_FSCK); > >> + f2fs_msg(sbi->sb, KERN_WARNING, > >> + "%s: orphan failed (ino=%x), run fsck to fix.", > >> + __func__, ino); > >> + return err; > >> } > >> > >> int recover_orphan_inodes(struct f2fs_sb_info *sbi) > >> > > > > . > >