From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752587AbeB1MeM (ORCPT ); Wed, 28 Feb 2018 07:34:12 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49166 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752482AbeB1MeK (ORCPT ); Wed, 28 Feb 2018 07:34:10 -0500 Date: Wed, 28 Feb 2018 20:33:59 +0800 From: Dave Young To: AKASHI Takahiro , catalin.marinas@arm.com, will.deacon@arm.com, bauerman@linux.vnet.ibm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, mpe@ellerman.id.au, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, julien.thierry@arm.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 02/13] kexec_file: make an use of purgatory optional Message-ID: <20180228123359.GB2228@dhcp-128-65.nay.redhat.com> References: <20180222111732.23051-1-takahiro.akashi@linaro.org> <20180222111732.23051-3-takahiro.akashi@linaro.org> <20180223084934.GB4433@dhcp-128-65.nay.redhat.com> <20180226102418.GD6019@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180226102418.GD6019@linaro.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/18 at 07:24pm, AKASHI Takahiro wrote: > On Fri, Feb 23, 2018 at 04:49:34PM +0800, Dave Young wrote: > > Hi AKASHI, > > > > On 02/22/18 at 08:17pm, AKASHI Takahiro wrote: > > > On arm64, no trampline code between old kernel and new kernel will be > > > required in kexec_file implementation. This patch introduces a new > > > configuration, ARCH_HAS_KEXEC_PURGATORY, and allows related code to be > > > compiled in only if necessary. > > > > Here also need the explanation about why no purgatory is needed, it would be > > required for kexec if no strong reason. > > OK, I will add the reason: > On arm64, crash dump kernel's usable memory is protected by > *unmapping* it from kernel virtual space unlike other architectures > where the region is just made read-only. > So our key developers think that it is highly unlikely that the region > is accidentally corrupted and this rationalizes that digest check code > be also dropped from purgatory. > This greatly simplifies our purgatory without any need for a bit ugly > relocation stuff, i.e. arch_kexec_apply_relocations_add(). > > Please see: > http://lists.infradead.org/pipermail/linux-arm-kernel/2017-December/545428.html > to find out how simple our purgatory was. All that it does is > to shuffle arguments and jump into a new kernel. > > Without this patch, we would have to have purgatory with a space for > a hash value (purgatory_sha256_digest) which is never checked against. > > Do you think it makes sense? Hmm, it looks reasonable, I remember there could be some performance issue for a purgatory because of cache disabled for arm64. I do not object this. [snip] Thanks Dave