From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932090AbeB1MiM (ORCPT ); Wed, 28 Feb 2018 07:38:12 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:39732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752206AbeB1MiL (ORCPT ); Wed, 28 Feb 2018 07:38:11 -0500 Date: Wed, 28 Feb 2018 20:38:00 +0800 From: Dave Young To: AKASHI Takahiro , catalin.marinas@arm.com, will.deacon@arm.com, bauerman@linux.vnet.ibm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, mpe@ellerman.id.au, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, julien.thierry@arm.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 03/13] kexec_file,x86,powerpc: factor out kexec_file_ops functions Message-ID: <20180228123800.GC2228@dhcp-128-65.nay.redhat.com> References: <20180222111732.23051-1-takahiro.akashi@linaro.org> <20180222111732.23051-4-takahiro.akashi@linaro.org> <20180223092459.GC4433@dhcp-128-65.nay.redhat.com> <20180226100138.GC6019@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180226100138.GC6019@linaro.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/18 at 07:01pm, AKASHI Takahiro wrote: > On Fri, Feb 23, 2018 at 05:24:59PM +0800, Dave Young wrote: > > Hi AKASHI, > > > > On 02/22/18 at 08:17pm, AKASHI Takahiro wrote: > > > As arch_kexec_kernel_*_{probe,load}(), arch_kimage_file_post_load_cleanup() > > > and arch_kexec_kernel_verify_sg can be parameterized with a kexec_file_ops > > > array and now duplicated among some architectures, let's factor them out. > > > > > > Signed-off-by: AKASHI Takahiro > > > Cc: Dave Young > > > Cc: Vivek Goyal > > > Cc: Baoquan He > > > Cc: Michael Ellerman > > > Cc: Thiago Jung Bauermann > > > --- > > > arch/powerpc/include/asm/kexec.h | 2 +- > > > arch/powerpc/kernel/kexec_elf_64.c | 2 +- > > > arch/powerpc/kernel/machine_kexec_file_64.c | 39 ++------------------ > > > arch/x86/include/asm/kexec-bzimage64.h | 2 +- > > > arch/x86/kernel/kexec-bzimage64.c | 2 +- > > > arch/x86/kernel/machine_kexec_64.c | 45 +---------------------- > > > include/linux/kexec.h | 15 ++++---- > > > kernel/kexec_file.c | 57 +++++++++++++++++++++++++++-- > > > 8 files changed, 70 insertions(+), 94 deletions(-) > > > > > > > [snip] > > > > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > > > index 990adae52151..a6d14a768b3e 100644 > > > --- a/kernel/kexec_file.c > > > +++ b/kernel/kexec_file.c > > > @@ -26,34 +26,83 @@ > > > #include > > > #include "kexec_internal.h" > > > > > > +const __weak struct kexec_file_ops * const kexec_file_loaders[] = {NULL}; > > > + > > > #ifdef CONFIG_ARCH_HAS_KEXEC_PURGATORY > > > static int kexec_calculate_store_digests(struct kimage *image); > > > #else > > > static int kexec_calculate_store_digests(struct kimage *image) { return 0; }; > > > #endif > > > > > > +int _kexec_kernel_image_probe(struct kimage *image, void *buf, > > > + unsigned long buf_len) > > > +{ > > > + const struct kexec_file_ops * const *fops; > > > + int ret = -ENOEXEC; > > > + > > > + for (fops = &kexec_file_loaders[0]; *fops && (*fops)->probe; ++fops) { > > > + ret = (*fops)->probe(buf, buf_len); > > > + if (!ret) { > > > + image->fops = *fops; > > > + return ret; > > > + } > > > + } > > > + > > > + return ret; > > > +} > > > + > > > /* Architectures can provide this probe function */ > > > int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf, > > > unsigned long buf_len) > > > { > > > - return -ENOEXEC; > > > + return _kexec_kernel_image_probe(image, buf, buf_len); > > > > > > I vaguely remember previously I suggest split the _kexec_kernel_image_probe > > because arch code can call them, and common code also use it like above. > > But in your new series I do not find where else calls this function > > except the common code arch_kexec_kernel_image_probe. If nobody use > > them then it is not worth to split them out, it is better to just embed > > them in the __weak functions. > > Powerpc's arch_kexec_kernel_image_probe() uses > _kexec_kekrnel_image_probe() as it needs an extra check to rule out > crash dump for now. Oops, I missed that, but what about other similar functions? Such as: _kexec_kernel_image_load _kimage_file_post_load_cleanup _kexec_kernel_verify_sig > > Thanks, > -Takahiro AKASHI > > > > Ditto for other similar functions. > > > > [snip] > > > > Thanks > > Dave Thanks Dave