From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: James Hogan <jhogan@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
MIPS Mailing List <linux-mips@linux-mips.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/8] MIPS: mscc: add ocelot dtsi
Date: Wed, 28 Feb 2018 14:14:02 +0100 [thread overview]
Message-ID: <20180228131402.GL1479@piout.net> (raw)
In-Reply-To: <CAOiHx=n5bekhgaA_-teYZzJQCErfb2Vg1X9fTaq073B=kpWnTA@mail.gmail.com>
On 27/02/2018 at 22:01:37 +0100, Jonas Gorski wrote:
> On 16 January 2018 at 11:12, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > Add a device tree include file for the Microsemi Ocelot SoC.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > arch/mips/boot/dts/Makefile | 1 +
> > arch/mips/boot/dts/mscc/Makefile | 4 ++
> > arch/mips/boot/dts/mscc/ocelot.dtsi | 110 ++++++++++++++++++++++++++++++++++++
> > 3 files changed, 115 insertions(+)
> > create mode 100644 arch/mips/boot/dts/mscc/Makefile
> > create mode 100644 arch/mips/boot/dts/mscc/ocelot.dtsi
> >
> > diff --git a/arch/mips/boot/dts/Makefile b/arch/mips/boot/dts/Makefile
> > index e2c6f131c8eb..1e79cab8e269 100644
> > --- a/arch/mips/boot/dts/Makefile
> > +++ b/arch/mips/boot/dts/Makefile
> > @@ -4,6 +4,7 @@ subdir-y += cavium-octeon
> > subdir-y += img
> > subdir-y += ingenic
> > subdir-y += lantiq
> > +subdir-y += mscc
> > subdir-y += mti
> > subdir-y += netlogic
> > subdir-y += ni
> > diff --git a/arch/mips/boot/dts/mscc/Makefile b/arch/mips/boot/dts/mscc/Makefile
> > new file mode 100644
> > index 000000000000..f0a155a74e02
> > --- /dev/null
> > +++ b/arch/mips/boot/dts/mscc/Makefile
> > @@ -0,0 +1,4 @@
> > +obj-y += $(patsubst %.dtb, %.dtb.o, $(dtb-y))
> > +
> > +# Force kbuild to make empty built-in.o if necessary
> > +obj- += dummy.o
> > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi
> > new file mode 100644
> > index 000000000000..b2f936e1fbb9
> > --- /dev/null
> > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi
> > @@ -0,0 +1,110 @@
> > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> > +/* Copyright (c) 2017 Microsemi Corporation */
> > +
> > +/ {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "mscc,ocelot";
> > +
> > + cpus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + mips-hpt-frequency = <250000000>;
> > +
> > + cpu@0 {
> > + compatible = "mscc,ocelot";
>
> You are using the same compatible string for the whole chip as well as
> the cpu core of it, this doesn't seem right.
>
> Also is this really a custom cpu core? Your product brief suggests
> this is a "normal" 24KEc MIPS CPU, at least for ocelot-10 (VSC7514).
> So something like "mips,mips24KEc" might be more appropriate here.
>
Indeed, that is something I forgot to change before sending.
>
> Regards
> Jonas
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-02-28 13:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 10:12 [PATCH v3 0/8] MIPS: add support for the Microsemi MIPS SoCs Alexandre Belloni
2018-01-16 10:12 ` [PATCH v3 1/8] dt-bindings: mips: Add bindings for Microsemi SoCs Alexandre Belloni
2018-01-19 19:23 ` Rob Herring
2018-02-14 16:38 ` James Hogan
2018-01-16 10:12 ` [PATCH v3 2/8] dt-bindings: power: reset: Document ocelot-reset binding Alexandre Belloni
2018-01-20 0:34 ` Rob Herring
2018-02-08 22:32 ` Sebastian Reichel
2018-01-16 10:12 ` [PATCH v3 3/8] power: reset: Add a driver for the Microsemi Ocelot reset Alexandre Belloni
2018-02-08 22:32 ` Sebastian Reichel
2018-01-16 10:12 ` [PATCH v3 4/8] MIPS: mscc: Add initial support for Microsemi MIPS SoCs Alexandre Belloni
2018-02-14 16:51 ` James Hogan
2018-02-14 21:38 ` Philippe Ombredanne
2018-01-16 10:12 ` [PATCH v3 5/8] MIPS: mscc: add ocelot dtsi Alexandre Belloni
2018-02-14 16:57 ` James Hogan
2018-02-27 15:47 ` Alexandre Belloni
2018-02-27 21:01 ` Jonas Gorski
2018-02-28 13:14 ` Alexandre Belloni [this message]
2018-01-16 10:12 ` [PATCH v3 6/8] MIPS: mscc: add ocelot PCB123 device tree Alexandre Belloni
2018-02-14 17:00 ` James Hogan
2018-02-27 15:54 ` Alexandre Belloni
2018-02-27 15:57 ` James Hogan
2018-01-16 10:12 ` [PATCH v3 7/8] MIPS: defconfigs: add a defconfig for Microsemi SoCs Alexandre Belloni
2018-02-14 17:03 ` James Hogan
2018-02-27 16:15 ` Alexandre Belloni
2018-02-27 16:23 ` James Hogan
2018-01-16 10:12 ` [PATCH v3 8/8] MAINTAINERS: Add entry for Microsemi MIPS SoCs Alexandre Belloni
2018-02-14 17:05 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228131402.GL1479@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=jhogan@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).