From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934042AbeB1TpD (ORCPT ); Wed, 28 Feb 2018 14:45:03 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:47694 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932351AbeB1To7 (ORCPT ); Wed, 28 Feb 2018 14:44:59 -0500 Date: Wed, 28 Feb 2018 19:44:49 +0000 From: Russell King To: Florian Fainelli Cc: netdev@vger.kernel.org, Andrew Lunn , open list Subject: Re: [PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset() Message-ID: <20180228194449.GB30733@flint.armlinux.org.uk> References: <20180228193612.29409-1-f.fainelli@gmail.com> <20180228193612.29409-6-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180228193612.29409-6-f.fainelli@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 28, 2018 at 11:36:12AM -0800, Florian Fainelli wrote: > We do the same thing as the generic function: nothing, so utilize it. > > Signed-off-by: Florian Fainelli > --- > drivers/net/phy/marvell10g.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c > index 8a0bd98fdec7..da014eae1476 100644 > --- a/drivers/net/phy/marvell10g.c > +++ b/drivers/net/phy/marvell10g.c > @@ -75,11 +75,6 @@ static int mv3310_probe(struct phy_device *phydev) > * Resetting the MV88X3310 causes it to become non-responsive. Avoid > * setting the reset bit(s). > */ > -static int mv3310_soft_reset(struct phy_device *phydev) > -{ > - return 0; > -} > - You do realise that getting rid of that function makes a nonsense of the comment above it - and removing the comment along with the function gets rid of the very important reason _why_ we have en empty reset method? > static int mv3310_config_init(struct phy_device *phydev) > { > __ETHTOOL_DECLARE_LINK_MODE_MASK(supported) = { 0, }; > @@ -377,7 +372,7 @@ static struct phy_driver mv3310_drivers[] = { > SUPPORTED_10000baseT_Full | > SUPPORTED_Backplane, > .probe = mv3310_probe, > - .soft_reset = mv3310_soft_reset, > + .soft_reset = gen10g_soft_reset, > .config_init = mv3310_config_init, > .config_aneg = mv3310_config_aneg, > .aneg_done = mv3310_aneg_done, > -- > 2.14.1 > -- Russell King ARM architecture Linux Kernel maintainer