From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nayna Jain <nayna@linux.vnet.ibm.com>
Cc: linux-integrity@vger.kernel.org, zohar@linux.vnet.ibm.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, peterhuewe@gmx.de,
tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com,
patrickc@us.ibm.com
Subject: Re: [PATCH 1/3] tpm: move TPM_POLL_SLEEP from tpm_tis_core.c to tpm.h
Date: Thu, 1 Mar 2018 10:37:40 +0200 [thread overview]
Message-ID: <20180301083740.GB29420@linux.intel.com> (raw)
In-Reply-To: <20180228191828.20056-1-nayna@linux.vnet.ibm.com>
Hi
On Wed, Feb 28, 2018 at 02:18:26PM -0500, Nayna Jain wrote:
> This patch moves TPM_POLL_SLEEP from tpm_tis_core.c to tpm.h, renaming
> it to TPM_TIMEOUT_POLL, to follow the existing enum naming
> conventions.
>
> Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
The cover letter is missing. Are this meant to be a patch set or
individual patches? I'll check these anyway.
> ---
> drivers/char/tpm/tpm.h | 3 ++-
> drivers/char/tpm/tpm_tis_core.c | 10 ++--------
> 2 files changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> index f895fba4e20d..7e797377e1eb 100644
> --- a/drivers/char/tpm/tpm.h
> +++ b/drivers/char/tpm/tpm.h
> @@ -53,7 +53,8 @@ enum tpm_const {
> enum tpm_timeout {
> TPM_TIMEOUT = 5, /* msecs */
> TPM_TIMEOUT_RETRY = 100, /* msecs */
> - TPM_TIMEOUT_RANGE_US = 300 /* usecs */
> + TPM_TIMEOUT_RANGE_US = 300, /* usecs */
What is happening here?
> + TPM_TIMEOUT_POLL = 1 /* msecs */
> };
>
> /* TPM addresses */
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index 183a5f54d875..dc474e7244a6 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -31,12 +31,6 @@
> #include "tpm.h"
> #include "tpm_tis_core.h"
>
> -/* This is a polling delay to check for status and burstcount.
> - * As per ddwg input, expectation is that status check and burstcount
> - * check should return within few usecs.
> - */
> -#define TPM_POLL_SLEEP 1 /* msec */
> -
> static void tpm_tis_clkrun_enable(struct tpm_chip *chip, bool value);
>
> static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask,
> @@ -90,7 +84,7 @@ static int wait_for_tpm_stat(struct tpm_chip *chip, u8 mask,
> }
> } else {
> do {
> - tpm_msleep(TPM_POLL_SLEEP);
> + tpm_msleep(TPM_TIMEOUT_POLL);
> status = chip->ops->status(chip);
> if ((status & mask) == mask)
> return 0;
> @@ -232,7 +226,7 @@ static int get_burstcount(struct tpm_chip *chip)
> burstcnt = (value >> 8) & 0xFFFF;
> if (burstcnt)
> return burstcnt;
> - tpm_msleep(TPM_POLL_SLEEP);
> + tpm_msleep(TPM_TIMEOUT_POLL);
> } while (time_before(jiffies, stop));
> return -EBUSY;
> }
> --
> 2.13.3
>
Otherwise, looks fine.
/Jarkko
next prev parent reply other threads:[~2018-03-01 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 19:18 [PATCH 1/3] tpm: move TPM_POLL_SLEEP from tpm_tis_core.c to tpm.h Nayna Jain
2018-02-28 19:18 ` [PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit() Nayna Jain
2018-03-01 9:22 ` Jarkko Sakkinen
2018-03-01 18:56 ` Nayna Jain
2018-03-05 10:56 ` Jarkko Sakkinen
2018-03-05 18:01 ` Jarkko Sakkinen
2018-03-05 19:07 ` Mimi Zohar
2018-03-06 11:06 ` Jarkko Sakkinen
2018-02-28 19:18 ` [RFC PATCH 3/3] tpm: tpm_msleep() with finer granularity improves performance Nayna Jain
2018-03-01 9:58 ` Jarkko Sakkinen
2018-03-02 8:13 ` Nayna Jain
2018-03-01 8:37 ` Jarkko Sakkinen [this message]
2018-03-01 18:44 ` [PATCH 1/3] tpm: move TPM_POLL_SLEEP from tpm_tis_core.c to tpm.h Nayna Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301083740.GB29420@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=patrickc@us.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd@selhorst.net \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).